Fix chrome upload with content uri

content/browser/child_process_security_policy_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_CHILD_PROCESS_SECURITY_POLICY_IMPL_H_
 #define CONTENT_BROWSER_CHILD_PROCESS_SECURITY_POLICY_IMPL_H_
 
 
 #include <map>
 #include <set>
@@ skipping 160 matching lines @@
   // --enable-strict-site-isolation or --site-per-process flags are used.
   bool CanSendCookiesForOrigin(int child_id, const GURL& gurl);
 
   // Sets the process as only permitted to use and see the cookies for the
   // given origin.
   // Only used if the very experimental --enable-strict-site-isolation or
   // --site-per-process flags are used.
   void LockToOrigin(int child_id, const GURL& gurl);
 
   // Determines if certain permissions were granted for a file fystem.
-  // |permissions| must be a bitwise-or'd value of base::PlatformFileFlags.
+  // |permissions| must be a bitwise-or'd value of
+  // ChildProcessSecurityPermissions.

[Tom Sepez, 2013/11/11 18:28:34]

Thanks for taking a stab at fixing this comment.  But
ChildProcessSecurityPermissions is declared in the .cc file, and shouldn't
appear here, since no public caller will be able to know about them. There's a
problem with the way this interface has evolved that is orthogonal to your CL. 
Please file a follow-up bug about this, assign it to tommycli@, and take this
out of your CL.  I'd like to see this fixed independently. 

[qinmin, 2013/11/11 20:49:53]

Done. crbug/317814 filed to track this.

On 2013/11/11 18:28:34, Tom Sepez wrote:

   bool HasPermissionsForFileSystem(
       int child_id,
       const std::string& filesystem_id,
       int permission);
 
   // Register FileSystem type and permission policy which should be used
   // for the type.  The |policy| must be a bitwise-or'd value of
   // fileapi::FilePermissionPolicy.
   void RegisterFileSystemPermissionPolicy(
       fileapi::FileSystemType type,
@@ skipping 18 matching lines @@
 
   // Obtain an instance of ChildProcessSecurityPolicyImpl via GetInstance().
   ChildProcessSecurityPolicyImpl();
   friend struct DefaultSingletonTraits<ChildProcessSecurityPolicyImpl>;
 
   // Adds child process during registration.
   void AddChild(int child_id);
 
   // Determines if certain permissions were granted for a file to given child
   // process. |permissions| must be a bitwise-or'd value of
-  // base::PlatformFileFlags.
+  // ChildProcessSecurityPermissions.
   bool ChildProcessHasPermissionsForFile(int child_id,
                                          const base::FilePath& file,
                                          int permissions);
 
   // Grant a particular permission set for a file. |permissions| is a bit-set
-  // of base::PlatformFileFlags.
+  // of ChildProcessSecurityPermissions.
   void GrantPermissionsForFile(int child_id,
                                const base::FilePath& file,
                                int permissions);
 
   // Grants access permission to the given isolated file system
   // identified by |filesystem_id|.  See comments for
   // ChildProcessSecurityPolicy::GrantReadFileSystem() for more details.
   void GrantPermissionsForFileSystem(
       int child_id,
       const std::string& filesystem_id,
       int permission);
 
   // Deprecated: Use CanReadFile, etc. methods instead.
   // Determines if certain permissions were granted for a file. |permissions|
-  // must be a bitwise-or'd value of base::PlatformFileFlags.
+  // must be a bitwise-or'd value of ChildProcessSecurityPermissions.
   bool HasPermissionsForFile(int child_id,
                              const base::FilePath& file,
                              int permissions);
 
   // Deprecated: Use CanReadFileSystemFile, etc. methods instead.
   // Determines if certain permissions were granted for a file in FileSystem
-  // API. |permissions| must be a bitwise-or'd value of base::PlatformFileFlags.
+  // API. |permissions| must be a bitwise-or'd value of
+  // ChildProcessSecurityPermissions.
   bool HasPermissionsForFileSystemFile(int child_id,
                                        const fileapi::FileSystemURL& url,
                                        int permissions);
 
   // You must acquire this lock before reading or writing any members of this
   // class.  You must not block while holding this lock.
   base::Lock lock_;
 
   // These schemes are white-listed for all child processes.  This set is
   // protected by |lock_|.
@@ skipping 15 matching lines @@
   WorkerToMainProcessMap worker_map_;
 
   FileSystemPermissionPolicyMap file_system_policy_map_;
 
   DISALLOW_COPY_AND_ASSIGN(ChildProcessSecurityPolicyImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_CHILD_PROCESS_SECURITY_POLICY_IMPL_H_