Fix chrome upload with content uri

content/browser/renderer_host/render_view_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_view_host_impl.h"
 
 #include <set>
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 1077 matching lines @@
 void RenderViewHostImpl::FilesSelectedInChooser(
     const std::vector<ui::SelectedFileInfo>& files,
     FileChooserParams::Mode permissions) {
   // Grant the security access requested to the given files.
   for (size_t i = 0; i < files.size(); ++i) {
     const ui::SelectedFileInfo& file = files[i];
     if (permissions == FileChooserParams::Save) {
       ChildProcessSecurityPolicyImpl::GetInstance()->GrantCreateReadWriteFile(
           GetProcess()->GetID(), file.local_path);
     } else {
+#if defined(OS_ANDROID)
+      GURL url(file.local_path.value());
+      if (url.SchemeIsContent()) {
+        ChildProcessSecurityPolicyImpl::GetInstance()->GrantReadContentUrl(
+            GetProcess()->GetID(), url);

[kinuko, 2013/10/29 02:52:31]

We receive this as file path and then at some point convert it to GURL if the
path can be interpret as content: URL.

What resources do content: URL refer? Can we always assume it points to a local
file resource? It looks if we delay this conversion point later we can remove
more OS_ANDROID code (e.g. we can change some of local file streams to
understand content: URL if it makes sense). Should we do so to limit the os
specific code or not?

[qinmin, 2013/10/29 19:14:21]

For upload case, the content url should point to a local file.
Yes, I think we can delay some of the conversion until we reach the
reading/getFileInfo stage. Also, some of the FilePath member functions are not
applicable to content urls, so I need to bypass those function.

I will do that in the next PS.

On 2013/10/29 02:52:31, kinuko wrote:

+      } else {
+#endif
       ChildProcessSecurityPolicyImpl::GetInstance()->GrantReadFile(
           GetProcess()->GetID(), file.local_path);
+#if defined(OS_ANDROID)
+      }
+#endif
     }
   }
   Send(new ViewMsg_RunFileChooserResponse(GetRoutingID(), files));
 }
 
 void RenderViewHostImpl::DirectoryEnumerationFinished(
     int request_id,
     const std::vector<base::FilePath>& files) {
   // Grant the security access requested to the given files.
   for (std::vector<base::FilePath>::const_iterator file = files.begin();
@@ skipping 1181 matching lines @@
 void RenderViewHostImpl::AttachToFrameTree() {
   FrameTree* frame_tree = delegate_->GetFrameTree();
 
   frame_tree->SwapMainFrame(main_render_frame_host_.get());
   if (main_frame_id() != FrameTreeNode::kInvalidFrameId) {
     frame_tree->OnFirstNavigationAfterSwap(main_frame_id());
   }
 }
 
 }  // namespace content