Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Side by Side Diff: content/browser/loader/upload_data_stream_builder.cc

Issue 46303005: Fix chrome upload with content uri (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/loader/upload_data_stream_builder.h" 5 #include "content/browser/loader/upload_data_stream_builder.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "net/base/upload_bytes_element_reader.h" 8 #include "net/base/upload_bytes_element_reader.h"
9 #include "net/base/upload_data_stream.h" 9 #include "net/base/upload_data_stream.h"
10 #include "net/base/upload_file_element_reader.h" 10 #include "net/base/upload_file_element_reader.h"
11 #include "webkit/browser/blob/blob_data_handle.h" 11 #include "webkit/browser/blob/blob_data_handle.h"
12 #include "webkit/browser/blob/blob_storage_context.h" 12 #include "webkit/browser/blob/blob_storage_context.h"
13 #include "webkit/browser/fileapi/upload_file_system_file_element_reader.h" 13 #include "webkit/browser/fileapi/upload_file_system_file_element_reader.h"
14 #include "webkit/common/resource_request_body.h" 14 #include "webkit/common/resource_request_body.h"
15 15
16 #if defined(OS_ANDROID)
17 #include "net/base/upload_content_url_element_reader_android.h"
18 #endif
19
16 using webkit_blob::BlobData; 20 using webkit_blob::BlobData;
17 using webkit_blob::BlobDataHandle; 21 using webkit_blob::BlobDataHandle;
18 using webkit_blob::BlobStorageContext; 22 using webkit_blob::BlobStorageContext;
19 using webkit_glue::ResourceRequestBody; 23 using webkit_glue::ResourceRequestBody;
20 24
21 namespace content { 25 namespace content {
22 namespace { 26 namespace {
23 27
24 // A subclass of net::UploadBytesElementReader which owns ResourceRequestBody. 28 // A subclass of net::UploadBytesElementReader which owns ResourceRequestBody.
25 class BytesElementReader : public net::UploadBytesElementReader { 29 class BytesElementReader : public net::UploadBytesElementReader {
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 } 61 }
58 62
59 virtual ~FileElementReader() {} 63 virtual ~FileElementReader() {}
60 64
61 private: 65 private:
62 scoped_refptr<ResourceRequestBody> resource_request_body_; 66 scoped_refptr<ResourceRequestBody> resource_request_body_;
63 67
64 DISALLOW_COPY_AND_ASSIGN(FileElementReader); 68 DISALLOW_COPY_AND_ASSIGN(FileElementReader);
65 }; 69 };
66 70
71 #if defined(OS_ANDROID)
72 // A subclass of net::UploadContentUrlElementReader which owns
73 // ResourceRequestBody.
74 class ContentUrlFileElementReader : public net::UploadContentUrlElementReader {
75 public:
76 ContentUrlFileElementReader(ResourceRequestBody* resource_request_body,
77 base::TaskRunner* task_runner,
78 const ResourceRequestBody::Element& element)
79 : net::UploadContentUrlElementReader(
80 task_runner,
kinuko 2013/10/29 02:52:31 nit: usually we indent not from ':' but from where
qinmin 2013/10/29 19:14:21 Done.
81 element.content_url(),
82 element.offset(),
83 element.length(),
84 element.expected_modification_time()),
85 resource_request_body_(resource_request_body) {
86 DCHECK_EQ(ResourceRequestBody::Element::TYPE_CONTENT_URL, element.type());
87 }
88
89 virtual ~ContentUrlFileElementReader() {}
90
91 private:
92 scoped_refptr<ResourceRequestBody> resource_request_body_;
93
94 DISALLOW_COPY_AND_ASSIGN(ContentUrlFileElementReader);
95 };
96 #endif
97
67 void ResolveBlobReference( 98 void ResolveBlobReference(
68 ResourceRequestBody* body, 99 ResourceRequestBody* body,
69 webkit_blob::BlobStorageContext* blob_context, 100 webkit_blob::BlobStorageContext* blob_context,
70 const ResourceRequestBody::Element& element, 101 const ResourceRequestBody::Element& element,
71 std::vector<const ResourceRequestBody::Element*>* resolved_elements) { 102 std::vector<const ResourceRequestBody::Element*>* resolved_elements) {
72 DCHECK(blob_context); 103 DCHECK(blob_context);
73 scoped_ptr<webkit_blob::BlobDataHandle> handle = 104 scoped_ptr<webkit_blob::BlobDataHandle> handle =
74 blob_context->GetBlobDataFromUUID(element.blob_uuid()); 105 blob_context->GetBlobDataFromUUID(element.blob_uuid());
75 DCHECK(handle); 106 DCHECK(handle);
76 if (!handle) 107 if (!handle)
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 break; 154 break;
124 case ResourceRequestBody::Element::TYPE_FILE_FILESYSTEM: 155 case ResourceRequestBody::Element::TYPE_FILE_FILESYSTEM:
125 element_readers.push_back( 156 element_readers.push_back(
126 new fileapi::UploadFileSystemFileElementReader( 157 new fileapi::UploadFileSystemFileElementReader(
127 file_system_context, 158 file_system_context,
128 element.filesystem_url(), 159 element.filesystem_url(),
129 element.offset(), 160 element.offset(),
130 element.length(), 161 element.length(),
131 element.expected_modification_time())); 162 element.expected_modification_time()));
132 break; 163 break;
164 #if defined(OS_ANDROID)
165 case ResourceRequestBody::Element::TYPE_CONTENT_URL:
166 element_readers.push_back(
167 new ContentUrlFileElementReader(body, file_task_runner, element));
168 break;
169 #endif
133 case ResourceRequestBody::Element::TYPE_BLOB: 170 case ResourceRequestBody::Element::TYPE_BLOB:
134 // Blob elements should be resolved beforehand. 171 // Blob elements should be resolved beforehand.
135 NOTREACHED(); 172 NOTREACHED();
136 break; 173 break;
137 case ResourceRequestBody::Element::TYPE_UNKNOWN: 174 case ResourceRequestBody::Element::TYPE_UNKNOWN:
138 NOTREACHED(); 175 NOTREACHED();
139 break; 176 break;
140 } 177 }
141 } 178 }
142 179
143 return make_scoped_ptr( 180 return make_scoped_ptr(
144 new net::UploadDataStream(element_readers.Pass(), body->identifier())); 181 new net::UploadDataStream(element_readers.Pass(), body->identifier()));
145 } 182 }
146 183
147 } // namespace content 184 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698