Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1455)

Unified Diff: build/common.gypi

Issue 463027: arm: Add thumb target and associated fixes (Closed)
Patch Set: fix comment Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | skia/skia.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 81838939784e24885663d6af016f88d680300e08..f2e72c97d2e51e07023ed0c75d31d5f6f736e1f1 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -200,6 +200,9 @@
# Set ARM-v7 compilation flags
'armv7%': 0,
+ # Set Thumb compilation flags.
+ 'arm_thumb%': 0,
+
'conditions': [
['OS=="linux"', {
# This will set gcc_version to XY if you are running gcc X.Y.*.
@@ -710,10 +713,27 @@
],
}],
['target_arch=="arm"', {
- 'conditions': [
- ['armv7==1', {
- 'target_conditions': [
- ['_toolset=="target"', {
+ 'target_conditions': [
+ ['_toolset=="target"', {
+ 'cflags_cc': [
+ # The codesourcery arm-2009q3 toolchain warns at that the ABI
+ # has changed whenever it encounters a varargs function. This
+ # silences those warnings, as they are not helpful and
+ # clutter legitimate warnings.
+ '-Wno-abi',
+ ],
+ 'conditions': [
+ ['arm_thumb == 1', {
+ 'cflags': [
+ '-mthumb',
+ # TODO(piman): -Wa,-mimplicit-it=thumb is needed for
+ # inline assembly that uses condition codes but it's
+ # suboptimal. Better would be to #ifdef __thumb__ at the
+ # right place and have a separate thumb path.
+ '-Wa,-mimplicit-it=thumb',
+ ]
+ }],
+ ['armv7==1', {
'cflags': [
'-march=armv7-a',
'-mtune=cortex-a8',
« no previous file with comments | « no previous file | skia/skia.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698