Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: tools/telemetry/telemetry/page/actions/play_unittest.py

Issue 463013003: [telemetry] Reduce waits and timeouts in unit tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/actions/play_unittest.py
diff --git a/tools/telemetry/telemetry/page/actions/play_unittest.py b/tools/telemetry/telemetry/page/actions/play_unittest.py
index dc2052ad5c2245386ae1eb8361659463c259a096..f2daf9c909e8f5232c4366f23ad9af15f807ec9d 100644
--- a/tools/telemetry/telemetry/page/actions/play_unittest.py
+++ b/tools/telemetry/telemetry/page/actions/play_unittest.py
@@ -64,7 +64,7 @@ class PlayActionTest(tab_test_case.TabTestCase):
def testPlayWaitForPlayTimeout(self):
"""Tests that wait_for_playing timeouts if video does not play."""
action = play.PlayAction(selector='#video_1',
- playing_event_timeout_in_seconds=1)
+ playing_event_timeout_in_seconds=0.1)
action.WillRunAction(self._tab)
self._tab.EvaluateJavaScript('document.getElementById("video_1").src = ""')
self.assertFalse(self._tab.EvaluateJavaScript(VIDEO_1_PLAYING_CHECK))
@@ -98,7 +98,7 @@ class PlayActionTest(tab_test_case.TabTestCase):
def testPlayWaitForEndedTimeout(self):
"""Tests that action raises exception if timeout is reached."""
action = play.PlayAction(selector='#video_1',
- ended_event_timeout_in_seconds=1)
+ ended_event_timeout_in_seconds=0.1)
action.WillRunAction(self._tab)
# Assert video not playing before running action.
self.assertFalse(self._tab.EvaluateJavaScript(VIDEO_1_PLAYING_CHECK))

Powered by Google App Engine
This is Rietveld 408576698