content/browser/service_worker/service_worker_provider_host.cc - Issue 463013002: ServiceWorker: Implement updatefound event and version attributes (Chromium)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_provider_host.cc

Issue 463013002: ServiceWorker: Implement updatefound event and version attributes (Chromium) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address for comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_dispatcher_host.cc ('k') | content/browser/service_worker/service_worker_registration_handle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_provider_host.cc

diff --git a/content/browser/service_worker/service_worker_provider_host.cc b/content/browser/service_worker/service_worker_provider_host.cc

index 340b8cfa4cf330ad9c0400463c8d0766391ae9c6..14e104434ae494ddda790f81f1e365e958c55fac 100644

--- a/content/browser/service_worker/service_worker_provider_host.cc

+++ b/content/browser/service_worker/service_worker_provider_host.cc

@@ -11,6 +11,7 @@

#include "content/browser/service_worker/service_worker_controllee_request_handler.h"

#include "content/browser/service_worker/service_worker_dispatcher_host.h"

#include "content/browser/service_worker/service_worker_handle.h"

+#include "content/browser/service_worker/service_worker_registration_handle.h"

#include "content/browser/service_worker/service_worker_utils.h"

#include "content/browser/service_worker/service_worker_version.h"

#include "content/common/service_worker/service_worker_messages.h"

@@ -99,7 +100,11 @@ void ServiceWorkerProviderHost::SetVersionAttributes(

attributes.active = CreateHandleAndPass(active_version);

dispatcher_host_->Send(new ServiceWorkerMsg_SetVersionAttributes(

- kDocumentMainThreadId, provider_id(), mask.changed(), attributes));

+ kDocumentMainThreadId,

+ provider_id(),

+ kInvalidServiceWorkerRegistrationHandleId,

+ mask.changed(),

+ attributes));

}

void ServiceWorkerProviderHost::SetVersionAttributesInternal(