Makes 'Cancel' the default button for extension install/uninstall confirmatio...

Makes 'Cancel' the default button for extension install/uninstall confirmation dialogs.

BUG=26357
TEST=try to install any extension on Mac, verify that the default (blue) button with the key equivalent of 'Return' is the abort action, NOT the install action.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33607

[Mark Mentovai, 2009-12-02 22:17:22]

LGTM

http://codereview.chromium.org/463008/diff/1/2
File chrome/browser/cocoa/extension_install_prompt.mm (right):

http://codereview.chromium.org/463008/diff/1/2#newcode28
chrome/browser/cocoa/extension_install_prompt.mm:28: // Clear the key equivalent
(currently 'Return') because we want cancel to be
If you rewrote this sentence without "we," it'd be shorter and clearer.

http://codereview.chromium.org/463008/diff/1/2#newcode31
chrome/browser/cocoa/extension_install_prompt.mm:31: NSButton* cancelButton =
[alert addButtonWithTitle:l10n_util::GetNSString(
I'd add some blank lines to this function to make the different button things
stand out.

A blank before each of the NSButton* junkButton = ... lines, and a blank after
each [junkButton setKeyEquivalent:...] line.

[Bons, 2009-12-02 22:19:58]

http://codereview.chromium.org/463008/diff/1/2
File chrome/browser/cocoa/extension_install_prompt.mm (right):

http://codereview.chromium.org/463008/diff/1/2#newcode28
chrome/browser/cocoa/extension_install_prompt.mm:28: // Clear the key equivalent
(currently 'Return') because we want cancel to be
On 2009/12/02 22:17:23, Mark Mentovai wrote:
> If you rewrote this sentence without "we," it'd be shorter and clearer.

Done.

http://codereview.chromium.org/463008/diff/1/2#newcode31
chrome/browser/cocoa/extension_install_prompt.mm:31: NSButton* cancelButton =
[alert addButtonWithTitle:l10n_util::GetNSString(
On 2009/12/02 22:17:23, Mark Mentovai wrote:
> I'd add some blank lines to this function to make the different button things
> stand out.
> 
> A blank before each of the NSButton* junkButton = ... lines, and a blank after
> each [junkButton setKeyEquivalent:...] line.

Done.

[Mark Mentovai, 2009-12-02 22:21:09]

LGTM