Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 462983002: GN: Make content_shell and webkit_unit_tests work in component build (Closed)

Created:
6 years, 4 months ago by jamesr
Modified:
6 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews, qsr+mojo_chromium.org, zea+watch_chromium.org, viettrungluu+watch_chromium.org, hguihot+watch_chromium.org, nasko+codewatch_chromium.org, yzshen+watch_chromium.org, ben+mojo_chromium.org, miu+watch_chromium.org, tim+watch_chromium.org, cbentzel+watch_chromium.org, imcheng+watch_chromium.org, jam, abarth-chromium, darin-cc_chromium.org, hubbe+watch_chromium.org, creis+watch_chromium.org, mikhal+watch_chromium.org, tdresser+watch_chromium.org, jasonroberts+watch_google.com, haitaol+watch_chromium.org, feature-media-reviews_chromium.org, piman+watch_chromium.org, maniscalco+watch_chromium.org, hclam+watch_chromium.org, avayvod+watch_chromium.org, pwestin+watch_google.com, Aaron Boodman, darin (slow to review)
Project:
chromium
Visibility:
Public.

Description

GN: Make content_shell and webkit_unit_tests work in component build Except for webrtc, this produces content_shell and webkit_unit_tests binaries that link and run successfully on linux. R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289007

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -37 lines) Patch
M build/config/linux/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/BUILD.gn View 2 chunks +3 lines, -2 lines 0 comments Download
M content/gpu/BUILD.gn View 2 chunks +5 lines, -0 lines 0 comments Download
M content/public/browser/BUILD.gn View 1 chunk +12 lines, -1 line 1 comment Download
M content/renderer/BUILD.gn View 2 chunks +5 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.h View 5 chunks +6 lines, -0 lines 1 comment Download
M content/renderer/render_thread_impl.cc View 3 chunks +9 lines, -4 lines 0 comments Download
M content/renderer/render_view_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 2 chunks +4 lines, -1 line 0 comments Download
M google_apis/gcm/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M ipc/mojo/BUILD.gn View 2 chunks +4 lines, -3 lines 0 comments Download
M jingle/BUILD.gn View 1 chunk +5 lines, -5 lines 0 comments Download
M media/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M media/cast/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M net/BUILD.gn View 4 chunks +9 lines, -3 lines 0 comments Download
M sync/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/boringssl/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/BUILD.gn View 3 chunks +17 lines, -13 lines 0 comments Download
M ui/gfx/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/wm/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jamesr
https://codereview.chromium.org/462983002/diff/1/content/public/browser/BUILD.gn File content/public/browser/BUILD.gn (right): https://codereview.chromium.org/462983002/diff/1/content/public/browser/BUILD.gn#newcode8 content/public/browser/BUILD.gn:8: group("browser") { without this patch various components were depending ...
6 years, 4 months ago (2014-08-12 04:03:08 UTC) #1
brettw
LGTM !!
6 years, 4 months ago (2014-08-12 05:54:34 UTC) #2
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 4 months ago (2014-08-12 05:56:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/462983002/1
6 years, 4 months ago (2014-08-12 05:58:10 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-12 07:21:55 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 07:25:52 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/3602)
6 years, 4 months ago (2014-08-12 07:25:54 UTC) #7
jamesr
6 years, 4 months ago (2014-08-12 17:07:19 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as 289007.

Powered by Google App Engine
This is Rietveld 408576698