Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Issue 462973002: Sheriff-O-Matic: Merge and update READMEs, add makefile for testing. (Closed)

Created:
6 years, 4 months ago by michaelpg
Modified:
6 years, 4 months ago
Reviewers:
ojan
CC:
abarth-chromium, blink-reviews, Dirk Pranke, dsinclair, dstockwell, leviw_travelin_and_unemployed, szager1
Project:
blink
Visibility:
Public.

Description

Sheriff-O-Matic: Merge and update READMEs, add makefile for testing. Sync: `make update` Run the tests: `make test` R=ojan@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180082

Patch Set 1 #

Total comments: 2

Patch Set 2 : rm echo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -53 lines) Patch
M Tools/GardeningServer/README View 2 chunks +64 lines, -14 lines 0 comments Download
D Tools/GardeningServer/README-mocha View 1 chunk +0 lines, -39 lines 0 comments Download
A Tools/GardeningServer/makefile View 1 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
michaelpg
PTAL, what do you think about using a makefile for easily syncing dependencies and running ...
6 years, 4 months ago (2014-08-12 03:17:33 UTC) #1
ojan
lgtm This is great! https://codereview.chromium.org/462973002/diff/1/Tools/GardeningServer/makefile File Tools/GardeningServer/makefile (right): https://codereview.chromium.org/462973002/diff/1/Tools/GardeningServer/makefile#newcode16 Tools/GardeningServer/makefile:16: @echo "npm and bower are ...
6 years, 4 months ago (2014-08-12 03:36:39 UTC) #2
michaelpg
https://codereview.chromium.org/462973002/diff/1/Tools/GardeningServer/makefile File Tools/GardeningServer/makefile (right): https://codereview.chromium.org/462973002/diff/1/Tools/GardeningServer/makefile#newcode16 Tools/GardeningServer/makefile:16: @echo "npm and bower are available." On 2014/08/12 03:36:39, ...
6 years, 4 months ago (2014-08-12 16:37:17 UTC) #3
michaelpg
The CQ bit was checked by michaelpg@chromium.org
6 years, 4 months ago (2014-08-12 16:38:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelpg@chromium.org/462973002/20001
6 years, 4 months ago (2014-08-12 16:39:04 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 16:40:08 UTC) #6
Message was sent while issue was closed.
Change committed as 180082

Powered by Google App Engine
This is Rietveld 408576698