Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 462913002: win: Add recipe to package Pro toolchain (Closed)

Created:
6 years, 4 months ago by scottmg
Modified:
6 years, 4 months ago
Reviewers:
iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Project:
tools
Visibility:
Public.

Description

win: Add recipe to package Pro toolchain Previously https://codereview.chromium.org/284663003/, this was done manually. This script attempts to automates that manual process. R=iannucci@chromium.org BUG=402543 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=288877

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -0 lines) Patch
A win_toolchain/package_from_installed.py View 1 1 chunk +155 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
scottmg
6 years, 4 months ago (2014-08-12 00:09:34 UTC) #1
iannucci
swoot. lgtm!
6 years, 4 months ago (2014-08-12 00:41:13 UTC) #2
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 4 months ago (2014-08-12 02:42:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/462913002/1
6 years, 4 months ago (2014-08-12 02:43:22 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 02:45:18 UTC) #5
commit-bot: I haz the power
Presubmit check for 462913002-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 4 months ago (2014-08-12 02:45:26 UTC) #6
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 4 months ago (2014-08-12 02:50:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/462913002/20001
6 years, 4 months ago (2014-08-12 02:51:30 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 02:53:18 UTC) #9
Message was sent while issue was closed.
Change committed as 288877

Powered by Google App Engine
This is Rietveld 408576698