Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.h

Issue 462853002: Cocoa extension install dialog instrumentation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sampling-extensions
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.h
diff --git a/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.h b/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.h
index 37e007e5a16161136a1f5bb8062af19325fd4d23..b1882721dbbadac11a31698c6fb989156566b3b0 100644
--- a/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.h
+++ b/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.h
@@ -16,6 +16,10 @@ class PageNavigator;
class WebContents;
}
+namespace extensions {
+class ExperienceSamplingEvent;
+}
+
@class ExtensionInstallViewController;
// Displays an extension install prompt as a tab modal dialog.
@@ -48,6 +52,7 @@ class ExtensionInstallDialogController :
ExtensionInstallPrompt::Delegate* delegate_;
base::scoped_nsobject<ExtensionInstallViewController> view_controller_;
scoped_ptr<ConstrainedWindowMac> constrained_window_;
+ scoped_ptr<extensions::ExperienceSamplingEvent> sampling_event_;
groby-ooo-7-16 2014/08/14 18:00:05 Question - why does this have object lifetime? Sho
Chris Thompson 2014/08/14 18:06:20 We want to also track when the UI was created/show
};
#endif // CHROME_BROWSER_UI_COCOA_EXTENSIONS_EXTENSION_INSTALL_DIALOG_CONTROLLER_H_

Powered by Google App Engine
This is Rietveld 408576698