Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1161)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 462843003: Cleanup namespace usage in public/platform/{Web[P-W]*,linux/*}.h (Closed)

Created:
6 years, 4 months ago by tkent
Modified:
6 years, 4 months ago
Reviewers:
keishi
CC:
blink-reviews, jamesr, shans, gavinp+prerender_chromium.org, Mike Lawther (Google), blink-reviews-animation_chromium.org, tzik, Timothy Loh, nhiroki, abarth-chromium, dstockwell, dglazkov+blink, darktears, rjwright, Steve Block, kinuko+fileapi, Eric Willigers
Project:
blink
Visibility:
Public.

Description

Cleanup namespace usage in public/platform/{Web[P-W]*,linux/*}.h - Merge multiple |namespace blink {}| blocks - Remove unnecessary blink:: prefixes - Make blank lines consistent BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180041

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -188 lines) Patch
M public/platform/WebPermissionCallbacks.h View 2 chunks +2 lines, -5 lines 0 comments Download
M public/platform/WebPoint.h View 1 chunk +4 lines, -4 lines 0 comments Download
M public/platform/WebPrerender.h View 3 chunks +4 lines, -6 lines 0 comments Download
M public/platform/WebPrivatePtr.h View 5 chunks +6 lines, -9 lines 0 comments Download
M public/platform/WebRTCConfiguration.h View 3 chunks +5 lines, -7 lines 0 comments Download
M public/platform/WebRTCDTMFSenderHandler.h View 1 chunk +1 line, -0 lines 0 comments Download
M public/platform/WebRTCDTMFSenderHandlerClient.h View 1 chunk +1 line, -0 lines 0 comments Download
M public/platform/WebRTCDataChannelHandler.h View 1 chunk +1 line, -0 lines 0 comments Download
M public/platform/WebRTCICECandidate.h View 1 chunk +0 lines, -4 lines 0 comments Download
M public/platform/WebRTCOfferOptions.h View 2 chunks +3 lines, -5 lines 0 comments Download
M public/platform/WebRTCPeerConnectionHandler.h View 1 chunk +1 line, -0 lines 0 comments Download
M public/platform/WebRTCPeerConnectionHandlerClient.h View 1 chunk +1 line, -0 lines 0 comments Download
M public/platform/WebRTCSessionDescriptionRequest.h View 2 chunks +3 lines, -5 lines 0 comments Download
M public/platform/WebRTCStatsRequest.h View 2 chunks +3 lines, -6 lines 0 comments Download
M public/platform/WebRTCStatsResponse.h View 2 chunks +4 lines, -6 lines 0 comments Download
M public/platform/WebRTCVoidRequest.h View 2 chunks +3 lines, -5 lines 0 comments Download
M public/platform/WebRect.h View 3 chunks +4 lines, -4 lines 0 comments Download
M public/platform/WebSchedulerProxy.h View 2 chunks +2 lines, -5 lines 0 comments Download
M public/platform/WebScrollOffsetAnimationCurve.h View 1 chunk +0 lines, -1 line 0 comments Download
M public/platform/WebScrollbar.h View 1 chunk +0 lines, -4 lines 0 comments Download
M public/platform/WebScrollbarLayer.h View 1 chunk +0 lines, -4 lines 0 comments Download
M public/platform/WebScrollbarThemePainter.h View 3 chunks +4 lines, -7 lines 0 comments Download
M public/platform/WebSerializedOrigin.h View 1 chunk +4 lines, -4 lines 0 comments Download
M public/platform/WebServiceWorkerProviderClient.h View 1 chunk +1 line, -0 lines 0 comments Download
M public/platform/WebServiceWorkerProxy.h View 2 chunks +5 lines, -5 lines 0 comments Download
M public/platform/WebServiceWorkerRequest.h View 1 chunk +2 lines, -2 lines 0 comments Download
M public/platform/WebServiceWorkerResponse.h View 2 chunks +3 lines, -6 lines 0 comments Download
M public/platform/WebSize.h View 1 chunk +4 lines, -4 lines 0 comments Download
M public/platform/WebSocketHandshakeRequestInfo.h View 2 chunks +3 lines, -6 lines 0 comments Download
M public/platform/WebSocketHandshakeResponseInfo.h View 2 chunks +3 lines, -6 lines 0 comments Download
M public/platform/WebSocketStreamError.h View 2 chunks +5 lines, -6 lines 0 comments Download
M public/platform/WebSpeechSynthesisUtterance.h View 2 chunks +6 lines, -6 lines 0 comments Download
M public/platform/WebSpeechSynthesisVoice.h View 2 chunks +3 lines, -5 lines 0 comments Download
M public/platform/WebStorageQuotaCallbacks.h View 2 chunks +2 lines, -5 lines 0 comments Download
M public/platform/WebThreadSafeData.h View 3 chunks +5 lines, -5 lines 0 comments Download
M public/platform/WebTransformAnimationCurve.h View 1 chunk +1 line, -2 lines 0 comments Download
M public/platform/WebURL.h View 2 chunks +6 lines, -6 lines 0 comments Download
M public/platform/WebURLError.h View 2 chunks +5 lines, -7 lines 0 comments Download
M public/platform/WebURLLoadTiming.h View 2 chunks +6 lines, -6 lines 0 comments Download
M public/platform/WebURLRequest.h View 2 chunks +3 lines, -6 lines 0 comments Download
M public/platform/WebURLResponse.h View 2 chunks +3 lines, -6 lines 0 comments Download
M public/platform/WebWorkerRunLoop.h View 2 chunks +3 lines, -5 lines 0 comments Download
M public/platform/linux/WebFontRenderStyle.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tkent
Please review this.
6 years, 4 months ago (2014-08-12 06:43:40 UTC) #1
keishi
LGTM
6 years, 4 months ago (2014-08-12 08:02:20 UTC) #2
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 4 months ago (2014-08-12 08:06:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/462843003/1
6 years, 4 months ago (2014-08-12 08:06:54 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 08:11:39 UTC) #5
Message was sent while issue was closed. 
Change committed as 180041

Powered by Google App Engine
This is Rietveld 408576698