Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 462813005: Make GN run when doing 32-bit cross-compiles on Linux. (Closed)

Created:
6 years, 4 months ago by brettw
Modified:
6 years, 4 months ago
Reviewers:
jamesr
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Make GN run when doing 32-bit cross-compiles on Linux. Previously, the breakpad client target wasn't getting compiled. R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289063

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -55 lines) Patch
M breakpad/BUILD.gn View 1 chunk +58 lines, -55 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
brettw
6 years, 4 months ago (2014-08-12 18:26:13 UTC) #1
jamesr
https://codereview.chromium.org/462813005/diff/1/breakpad/BUILD.gn File breakpad/BUILD.gn (right): https://codereview.chromium.org/462813005/diff/1/breakpad/BUILD.gn#newcode328 breakpad/BUILD.gn:328: if (current_toolchain == host_toolchain) { sorry i'm think - ...
6 years, 4 months ago (2014-08-12 18:28:15 UTC) #2
brettw
The point is that "client" moved out of the toolchain check and only gets the ...
6 years, 4 months ago (2014-08-12 18:29:21 UTC) #3
jamesr
Ahh right, the indentation should have clued me in lgtm
6 years, 4 months ago (2014-08-12 19:19:02 UTC) #4
brettw
6 years, 4 months ago (2014-08-12 21:31:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as 289063.

Powered by Google App Engine
This is Rietveld 408576698