Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 462783002: Get rid of delayed runnable and change visibility instead for ContentViewRenderView (Closed)

Created:
6 years, 4 months ago by Yusuf
Modified:
6 years, 4 months ago
Reviewers:
Ted C
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Get rid of delayed runnable and change visibility instead for ContentViewRenderView A better fix to not missing any callbacks during Java initialization is setting the SurfaceView visibility to VISIBLE only after libraries has loaded. This change removes the delayedRunnable setup and adds an assert to make sure we dont have a valid surface before native load. BUG=401581 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288901

Patch Set 1 #

Total comments: 2

Patch Set 2 : Indentation fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -69 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java View 1 7 chunks +4 lines, -69 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Yusuf
6 years, 4 months ago (2014-08-11 18:29:08 UTC) #1
Ted C
lgtm https://codereview.chromium.org/462783002/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java File content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java (right): https://codereview.chromium.org/462783002/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java#newcode64 content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java:64: "Surface created before native library loaded."; +4 indent
6 years, 4 months ago (2014-08-11 23:53:38 UTC) #2
Yusuf
https://codereview.chromium.org/462783002/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java File content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java (right): https://codereview.chromium.org/462783002/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java#newcode64 content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java:64: "Surface created before native library loaded."; On 2014/08/11 23:53:38, ...
6 years, 4 months ago (2014-08-11 23:56:52 UTC) #3
Yusuf
The CQ bit was checked by yusufo@chromium.org
6 years, 4 months ago (2014-08-11 23:57:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusufo@chromium.org/462783002/20001
6 years, 4 months ago (2014-08-12 00:01:34 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-12 00:50:54 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 03:30:03 UTC) #7
Message was sent while issue was closed.
Change committed as 288901

Powered by Google App Engine
This is Rietveld 408576698