Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Side by Side Diff: Source/core/html/track/TextTrackCueList.h

Issue 462653002: Oilpan: remove unnecessary TextTrackList finalization. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/html/track/TextTrackCueList.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 16 matching lines...) Expand all
27 #define TextTrackCueList_h 27 #define TextTrackCueList_h
28 28
29 #include "bindings/core/v8/ScriptWrappable.h" 29 #include "bindings/core/v8/ScriptWrappable.h"
30 #include "core/html/track/TextTrackCue.h" 30 #include "core/html/track/TextTrackCue.h"
31 #include "wtf/PassRefPtr.h" 31 #include "wtf/PassRefPtr.h"
32 #include "wtf/RefCounted.h" 32 #include "wtf/RefCounted.h"
33 #include "wtf/Vector.h" 33 #include "wtf/Vector.h"
34 34
35 namespace blink { 35 namespace blink {
36 36
37 class TextTrackCueList FINAL : public RefCountedWillBeGarbageCollectedFinalized< TextTrackCueList>, public ScriptWrappable { 37 class TextTrackCueList FINAL : public RefCountedWillBeGarbageCollected<TextTrack CueList>, public ScriptWrappable {
38 DECLARE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED(TextTrackCueList);
38 public: 39 public:
39 static PassRefPtrWillBeRawPtr<TextTrackCueList> create() 40 static PassRefPtrWillBeRawPtr<TextTrackCueList> create()
40 { 41 {
41 return adoptRefWillBeNoop(new TextTrackCueList); 42 return adoptRefWillBeNoop(new TextTrackCueList);
42 } 43 }
43 44
44 ~TextTrackCueList() { }
45
46 unsigned long length() const; 45 unsigned long length() const;
47 unsigned long getCueIndex(TextTrackCue*) const; 46 unsigned long getCueIndex(TextTrackCue*) const;
48 47
49 TextTrackCue* item(unsigned index) const; 48 TextTrackCue* item(unsigned index) const;
50 TextTrackCue* getCueById(const AtomicString&) const; 49 TextTrackCue* getCueById(const AtomicString&) const;
51 TextTrackCueList* activeCues(); 50 TextTrackCueList* activeCues();
52 51
53 bool add(PassRefPtrWillBeRawPtr<TextTrackCue>); 52 bool add(PassRefPtrWillBeRawPtr<TextTrackCue>);
54 bool remove(TextTrackCue*); 53 bool remove(TextTrackCue*);
55 bool contains(TextTrackCue*) const; 54 bool contains(TextTrackCue*) const;
56 55
57 bool updateCueIndex(TextTrackCue*); 56 bool updateCueIndex(TextTrackCue*);
58 57
59 void trace(Visitor*); 58 void trace(Visitor*);
60 59
61 private: 60 private:
62 TextTrackCueList(); 61 TextTrackCueList();
63 bool add(PassRefPtrWillBeRawPtr<TextTrackCue>, size_t, size_t); 62 bool add(PassRefPtrWillBeRawPtr<TextTrackCue>, size_t, size_t);
64 void clear(); 63 void clear();
65 void invalidateCueIndexes(size_t); 64 void invalidateCueIndexes(size_t);
66 65
67 WillBeHeapVector<RefPtrWillBeMember<TextTrackCue> > m_list; 66 WillBeHeapVector<RefPtrWillBeMember<TextTrackCue> > m_list;
68 RefPtrWillBeMember<TextTrackCueList> m_activeCues; 67 RefPtrWillBeMember<TextTrackCueList> m_activeCues;
69
70 }; 68 };
71 69
72 } // namespace blink 70 } // namespace blink
73 71
74 #endif 72 #endif
OLDNEW
« no previous file with comments | « no previous file | Source/core/html/track/TextTrackCueList.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698