Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Issue 462633003: Provide mutators in NodeProperties instead of exposing indicies. (Closed)

Created:
6 years, 4 months ago by sigurds
Modified:
6 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
rossberg
Project:
v8
Visibility:
Public.

Description

Provide mutators in NodeProperties instead of exposing indicies. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23074

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M src/compiler/node-properties.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/compiler/node-properties-inl.h View 5 chunks +10 lines, -10 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
sigurds
6 years, 4 months ago (2014-08-11 13:22:54 UTC) #1
Michael Starzinger
LGTM, I like it.
6 years, 4 months ago (2014-08-11 18:20:29 UTC) #2
sigurds
6 years, 4 months ago (2014-08-12 12:20:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 23074 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698