Chromium Code Reviews| Index: Source/bindings/templates/methods.cpp |
| diff --git a/Source/bindings/templates/methods.cpp b/Source/bindings/templates/methods.cpp |
| index a7733bc9d8386b7c2f60793b417a4f9d0b38f431..2ace15506661be62388ea8c41fe9f5035fd7e342 100644 |
| --- a/Source/bindings/templates/methods.cpp |
| +++ b/Source/bindings/templates/methods.cpp |
| @@ -529,14 +529,17 @@ bool {{v8_class}}::PrivateScript::{{method.name}}Method({{method.argument_declar |
| {% if method.idl_type == 'void' %} |
| PrivateScriptRunner::runDOMMethod(scriptState, "{{cpp_class}}", "{{method.name}}", holder, {{method.arguments | length}}, argv); |
| if (block.HasCaught()) { |
| - PrivateScriptRunner::throwDOMExceptionInPrivateScriptIfNeeded(scriptState->isolate(), exceptionState, block.Exception()); |
| - return false; |
| + if (!PrivateScriptRunner::throwDOMExceptionInPrivateScriptIfNeeded(scriptState->isolate(), exceptionState, block.Exception())); { |
| + // FIXME: We should support more exceptions. |
| + RELEASE_ASSERT_NOT_REACHED(); |
| + return false; |
|
Jens Widell
2014/08/11 11:35:34
This line should be outside/below this if-statemen
|
| + } |
| } |
| {% else %} |
| v8::Handle<v8::Value> v8Value = PrivateScriptRunner::runDOMMethod(scriptState, "{{cpp_class}}", "{{method.name}}", holder, {{method.arguments | length}}, argv); |
| if (block.HasCaught()) { |
| if (!PrivateScriptRunner::throwDOMExceptionInPrivateScriptIfNeeded(scriptState->isolate(), exceptionState, block.Exception())) { |
| - // FIXME: We should support exceptions other than DOM exceptions. |
| + // FIXME: We should support more exceptions. |
| RELEASE_ASSERT_NOT_REACHED(); |
| } |
| return false; |