Add a missing check for exceptions thrown in methods implemented in private scripts

Add a missing check for exceptions thrown in methods implemented in private scripts

method.cpp misses a check for a returned value of a method implemented in a private script.
This CL adds the check. Other places already have the check.

(This call path is not yet used in production.)

BUG=341031
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179943

[haraken, 2014-08-11 11:32:29]

PTAL

[Jens Widell, 2014-08-11 11:35:34]

https://codereview.chromium.org/462623002/diff/1/Source/bindings/templates/me...
File Source/bindings/templates/methods.cpp (right):

https://codereview.chromium.org/462623002/diff/1/Source/bindings/templates/me...
Source/bindings/templates/methods.cpp:535: return false;
This line should be outside/below this if-statement.

[haraken, 2014-08-11 11:36:00]

On 2014/08/11 11:35:34, Jens Lindström wrote:
>
https://codereview.chromium.org/462623002/diff/1/Source/bindings/templates/me...
> File Source/bindings/templates/methods.cpp (right):
> 
>
https://codereview.chromium.org/462623002/diff/1/Source/bindings/templates/me...
> Source/bindings/templates/methods.cpp:535: return false;
> This line should be outside/below this if-statement.

Yes, I fixed it before you reviewed it :)

[Jens Widell, 2014-08-11 11:39:07]

On 2014/08/11 11:36:00, haraken wrote:
> On 2014/08/11 11:35:34, Jens Lindström wrote:
> >
>
https://codereview.chromium.org/462623002/diff/1/Source/bindings/templates/me...
> > File Source/bindings/templates/methods.cpp (right):
> > 
> >
>
https://codereview.chromium.org/462623002/diff/1/Source/bindings/templates/me...
> > Source/bindings/templates/methods.cpp:535: return false;
> > This line should be outside/below this if-statement.
> 
> Yes, I fixed it before you reviewed it :)

Race conditions are always tricky to avoid completely.  :-)

LGTM

[haraken, 2014-08-11 11:40:06]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-08-11 11:40:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haraken@chromium.org/462623002/20001

[haraken, 2014-08-11 11:46:47]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-08-11 11:46:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haraken@chromium.org/462623002/60001

[commit-bot: I haz the power, 2014-08-11 12:47:41]

Change committed as 179943