build/android/pylib/instrumentation/test_runner.py - Issue 462613005: Test Runner changes for @IntegrationTest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/instrumentation/test_runner.py

Issue 462613005: Test Runner changes for @IntegrationTest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/pylib/instrumentation/test_runner.py

diff --git a/build/android/pylib/instrumentation/test_runner.py b/build/android/pylib/instrumentation/test_runner.py

index 5711291a20af39403301e75662638768e44b3e08..04e167230f23ce6fdaee0183cf487418eb755513 100644

--- a/build/android/pylib/instrumentation/test_runner.py

+++ b/build/android/pylib/instrumentation/test_runner.py

@@ -166,7 +166,8 @@ class TestRunner(base_test_runner.BaseTestRunner):

self.flags.AddFlags(['--disable-fre', '--enable-test-intents'])

if self.options.device_flags:

with open(self.options.device_flags) as device_flags_file:

- self.flags.AddFlags(list(device_flags_file))

+ self.flags.AddFlags([flag.replace('\n','') \

jbudorick 2014/08/11 19:31:47 nit: Just use strip() to remove the trailing newli

+ for flag in device_flags_file if flag != '\n'])

def TearDown(self):

"""Cleans up the test harness and saves outstanding data from test run."""

« no previous file with comments | « build/android/pylib/instrumentation/test_jar.py ('k') | no next file » | no next file with comments »