Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 462613004: IDL parser: clean up cached lexer table updating code (Closed)

Created:
6 years, 4 months ago by Jens Widell
Modified:
6 years, 4 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

IDL parser: clean up cached lexer table updating code Follow-up to https://codereview.chromium.org/425953002/ addressing some late comments. BUG=397909 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179971

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M Source/bindings/scripts/blink_idl_lexer.py View 3 chunks +7 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Jens Widell
nbarth@: style adjustments, as you suggested. :-)
6 years, 4 months ago (2014-08-11 15:57:48 UTC) #1
Nils Barth (inactive)
Thanks, LGTM!
6 years, 4 months ago (2014-08-11 15:59:03 UTC) #2
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 4 months ago (2014-08-11 16:11:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/462613004/1
6 years, 4 months ago (2014-08-11 16:13:08 UTC) #4
commit-bot: I haz the power
Change committed as 179971
6 years, 4 months ago (2014-08-11 17:13:04 UTC) #5
haraken
6 years, 4 months ago (2014-08-11 23:24:26 UTC) #6
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698