Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 462603002: Make console.timeline/timelineEnd work for Timeline based on trace events (Closed)

Created:
6 years, 4 months ago by yurys
Modified:
6 years, 4 months ago
Reviewers:
alph, sergeyv
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Make console.timeline/timelineEnd work for Timeline based on trace events BUG=398787 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179964

Patch Set 1 #

Patch Set 2 : Send message only when Timeline is based on trace events #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Source/core/inspector/InspectorConsoleAgent.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/Target.js View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
yurys
6 years, 4 months ago (2014-08-11 11:21:56 UTC) #1
alph
lgtm
6 years, 4 months ago (2014-08-11 11:22:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/462603002/1
6 years, 4 months ago (2014-08-11 11:23:17 UTC) #3
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 4 months ago (2014-08-11 11:41:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/462603002/20001
6 years, 4 months ago (2014-08-11 11:42:16 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-11 12:45:13 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-11 13:24:47 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/22050)
6 years, 4 months ago (2014-08-11 13:24:48 UTC) #8
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 4 months ago (2014-08-11 13:39:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/462603002/20001
6 years, 4 months ago (2014-08-11 13:39:40 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-11 14:44:45 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 15:18:17 UTC) #12
Message was sent while issue was closed. 
Change committed as 179964

Powered by Google App Engine
This is Rietveld 408576698