Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 462593002: Support invalidation sets for negated selectors. (Closed)

Created:
6 years, 4 months ago by rune
Modified:
6 years, 4 months ago
Reviewers:
esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@tmp-upstream
Project:
blink
Visibility:
Public.

Description

Support invalidation sets for negated selectors. Add invalidation set features to invalidation sets for negated classes, ids, etc. But still treat negated features as universal selectors and trigger subtree recalc. Example selector -> invalidation set mappings: ":not(.a)" -> ".a {}" ":not(.a) .b" -> ".b {}, .a { .b }" ".a :not(.b)" -> ".a { * }, .b {}" ".a .b:not(.c)" -> ".a { .b }, .b {}, .c {}" BUG=377939 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180632

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -11 lines) Patch
A LayoutTests/fast/css/invalidation/invalidation-set-not.html View 1 chunk +104 lines, -0 lines 0 comments Download
M LayoutTests/fast/css/invalidation/targeted-class-host-pseudo.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/invalidation/targeted-class-host-pseudo-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/RuleFeature.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/RuleFeature.cpp View 1 3 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
esprehn
6 years, 4 months ago (2014-08-19 01:17:48 UTC) #1
esprehn
lgtm, this seems pretty reasonable. We can add more complexity when we find that :not() ...
6 years, 4 months ago (2014-08-19 01:28:56 UTC) #2
rune
The CQ bit was checked by rune@opera.com
6 years, 4 months ago (2014-08-19 21:47:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/462593002/20001
6 years, 4 months ago (2014-08-19 21:47:47 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-19 23:02:11 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-19 23:42:40 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/23542)
6 years, 4 months ago (2014-08-19 23:42:41 UTC) #7
rune
The CQ bit was checked by rune@opera.com
6 years, 4 months ago (2014-08-20 05:14:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/462593002/20001
6 years, 4 months ago (2014-08-20 05:15:14 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-20 05:28:48 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-20 05:52:09 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/23581)
6 years, 4 months ago (2014-08-20 05:52:10 UTC) #12
rune
The CQ bit was checked by rune@opera.com
6 years, 4 months ago (2014-08-20 06:18:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/462593002/20001
6 years, 4 months ago (2014-08-20 06:18:48 UTC) #14
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 07:08:24 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180632

Powered by Google App Engine
This is Rietveld 408576698