Issue 462563003: Mojo: Plumb "connection broken" out of RawChannel.

Issue 462563003: Mojo: Plumb "connection broken" out of RawChannel. (Closed)

Created:
6 years, 4 months ago by viettrungluu

Modified:
6 years, 4 months ago

Reviewers:
yzshen1

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Mojo: Plumb "connection broken" out of RawChannel. (Not yet for Windows -- I don't know if I can make the distinction between closed and broken on Windows ... and won't be able to check until my Windows machine works again.) R=yzshen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288837

Patch Set 1 #

Total comments: 2

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -10 lines)			Patch
M	mojo/system/channel.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	mojo/system/raw_channel.h	View	3 chunks	+8 lines, -0 lines	0 comments	Download
M	mojo/system/raw_channel.cc	View	2 chunks	+20 lines, -4 lines	0 comments	Download
M	mojo/system/raw_channel_posix.cc	View	1 chunk	+10 lines, -6 lines	2 comments	Download
M	mojo/system/raw_channel_unittest.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

yzshen1

lgtm https://codereview.chromium.org/462563003/diff/1/mojo/system/raw_channel_posix.cc File mojo/system/raw_channel_posix.cc (right): https://codereview.chromium.org/462563003/diff/1/mojo/system/raw_channel_posix.cc#newcode198 mojo/system/raw_channel_posix.cc:198: return IO_FAILED_UNKNOWN; Btw, do we need read_watcher_.reset() here?

6 years, 4 months ago (2014-08-11 20:45:13 UTC) #2

viettrungluu

Thanks. https://codereview.chromium.org/462563003/diff/1/mojo/system/raw_channel_posix.cc File mojo/system/raw_channel_posix.cc (right): https://codereview.chromium.org/462563003/diff/1/mojo/system/raw_channel_posix.cc#newcode198 mojo/system/raw_channel_posix.cc:198: return IO_FAILED_UNKNOWN; On 2014/08/11 20:45:12, yzshen1 wrote: > ...

6 years, 4 months ago (2014-08-11 20:58:29 UTC) #3

viettrungluu

6 years, 4 months ago (2014-08-12 00:18:10 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as 288837 (presubmit successful).

Expand Messages | Collapse Messages