chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm - Issue 462563002: Add ManagePasswordsBubbleManageViewController and unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm

Issue 462563002: Add ManagePasswordsBubbleManageViewController and unit tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix views Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_manage_view_controller_unittest.mm ('k') | chrome/browser/ui/passwords/manage_passwords_bubble_model.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm

diff --git a/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm b/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm

index 65cc31d42938a3cef351063ba7414d82b94a3e1e..ed127269dac87e924b1297eb169bfa69e5c1445c 100644

--- a/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm

+++ b/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm

@@ -78,11 +78,10 @@ using namespace password_manager::mac::ui;

// Password item.

// It should be at least as wide as the box without the padding.

- const CGFloat itemMinWidth = kDesiredBubbleWidth - 2 * kFramePadding;

passwordItem_.reset([[ManagePasswordItemViewController alloc]

initWithModel:model_

- position:password_manager::ui::FIRST_ITEM

- minWidth:itemMinWidth]);

+ passwordForm:model_->pending_credentials()

+ position:password_manager::ui::FIRST_ITEM]);

NSView* password = [passwordItem_ view];

[self.view addSubview:password];