Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6210)

Unified Diff: chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_controller_unittest.mm

Issue 462563002: Add ManagePasswordsBubbleManageViewController and unit tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix views Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_controller_unittest.mm b/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_controller_unittest.mm
index 6956200ab2a4e10a3fa4c7ace91f7ead2a9481fe..456fc30ce1e9b0301da53c0397649d92f9861423 100644
--- a/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_controller_unittest.mm
@@ -12,6 +12,8 @@
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/cocoa/cocoa_test_helper.h"
#import "chrome/browser/ui/cocoa/info_bubble_window.h"
+#import "chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_manage_view_controller.h"
+#import "chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.h"
#include "chrome/browser/ui/cocoa/passwords/manage_passwords_controller_test.h"
#include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -27,7 +29,6 @@ class ManagePasswordsBubbleControllerTest
virtual void SetUp() OVERRIDE {
ManagePasswordsControllerTest::SetUp();
- model()->set_state(password_manager::ui::PENDING_PASSWORD_STATE);
}
ManagePasswordsBubbleController* controller() {
@@ -44,12 +45,13 @@ class ManagePasswordsBubbleControllerTest
};
TEST_F(ManagePasswordsBubbleControllerTest, PendingStateShouldHavePendingView) {
- // We start in the pending state.
+ model()->set_state(password_manager::ui::PENDING_PASSWORD_STATE);
EXPECT_EQ([ManagePasswordsBubblePendingViewController class],
[[controller() currentController] class]);
}
TEST_F(ManagePasswordsBubbleControllerTest, DismissingShouldCloseWindow) {
+ model()->set_state(password_manager::ui::PENDING_PASSWORD_STATE);
[controller() showWindow:nil];
// Turn off animations so that closing happens immediately.
@@ -62,4 +64,10 @@ TEST_F(ManagePasswordsBubbleControllerTest, DismissingShouldCloseWindow) {
EXPECT_FALSE([window isVisible]);
}
+TEST_F(ManagePasswordsBubbleControllerTest, ManageStateShouldHaveManageView) {
+ model()->set_state(password_manager::ui::MANAGE_STATE);
+ EXPECT_EQ([ManagePasswordsBubbleManageViewController class],
+ [[controller() currentController] class]);
+}
+
} // namespace

Powered by Google App Engine
This is Rietveld 408576698