Add optional startIndex to String.replaceFirst

tests/corelib/string_replace_test.dart

Index: tests/corelib/string_replace_test.dart
diff --git a/tests/corelib/string_replace_test.dart b/tests/corelib/string_replace_test.dart
index 136cc960d88baabcedcd41111cfe3297740dffb1..48397204a875b252d03d7929f6bf83da8747b3ec 100644
--- a/tests/corelib/string_replace_test.dart
+++ b/tests/corelib/string_replace_test.dart
@@ -42,6 +42,52 @@ class StringReplaceTest {
 
     // Test replacing the empty string.
     Expect.equals("toAtoBtoCto", "AtoBtoCto".replaceFirst("", "to"));
+
+    // Test startIndex.
+    Expect.equals(
+        "foo-AAA-foo-bar", "foo-bar-foo-bar".replaceFirst("bar", "AAA", 4));
+
+    // Test startIndex skipping one case at the begining.
+    Expect.equals(
+        "foo-bar-AAA-bar", "foo-bar-foo-bar".replaceFirst("foo", "AAA", 1));
+
+    // Test startIndex skipping one case at the begining.
+    Expect.equals(
+        "foo-bar-foo-AAA", "foo-bar-foo-bar".replaceFirst("bar", "AAA", 5));
+
+    // Test startIndex replacing with the empty string.
+    Expect.equals(
+        "foo-bar--bar", "foo-bar-foo-bar".replaceFirst("foo", "", 1));
+
+    // Test startIndex with a RegExp with carat
+    Expect.equals(
+        "foo-bar-foo-bar",
+        "foo-bar-foo-bar".replaceFirst(new RegExp(r"^foo"), "", 8));
+
+    // Test startIndex with a RegExp
+    Expect.equals(
+        "aaa{3}X{3}", "aaa{3}aaa{3}".replaceFirst(new RegExp(r"a{3}"), "X", 1));
+
+    // Test startIndex with regexp-looking String
+    Expect.equals(
+        "aaa{3}aaX", "aaa{3}aaa{3}".replaceFirst("a{3}", "X", 3));
+
+    // Test negative startIndex
+    Expect.throws(
+        () => "hello".replaceFirst("h", "X", -1), (e) => e is RangeError);
+
+    // Test startIndex too large
+    Expect.throws(
+        () => "hello".replaceFirst("h", "X", 6), (e) => e is RangeError);
+
+    // Test null startIndex
+    Expect.throws(
+        () => "hello".replaceFirst("h", "X", null), (e) => e is ArgumentError);
+
+    // Test object startIndex
+    Expect.throws(
+        () => "hello".replaceFirst("h", "X", new Object()),
+        (e) => e is TypeError);

[Lasse Reichstein Nielsen, 2014/08/20 08:58:53]

This is only correct in checked mode on the VM. In unchecked mode it is an
ArgumentError.
I'd just drop the type check, and be happy that it throws.

[srawlins, 2014/08/22 14:46:40]

Done.

   }
 }