Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Unified Diff: sdk/lib/_internal/lib/js_string.dart

Issue 462463003: Add optional startIndex to String.replaceFirst (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/lib/js_string.dart
diff --git a/sdk/lib/_internal/lib/js_string.dart b/sdk/lib/_internal/lib/js_string.dart
index 36372f46c9caee94754fe3ae48935c9a4d676443..fe2bd0beb4632b32a98dd5c7dc7c4b3a972aa4a5 100644
--- a/sdk/lib/_internal/lib/js_string.dart
+++ b/sdk/lib/_internal/lib/js_string.dart
@@ -66,9 +66,12 @@ class JSString extends Interceptor implements String, JSIndexable {
return stringReplaceAllFuncUnchecked(this, from, onMatch, onNonMatch);
}
- String replaceFirst(Pattern from, String to) {
+ String replaceFirst(Pattern from, String to, [int startIndex = 0]) {
checkString(to);
- return stringReplaceFirstUnchecked(this, from, to);
+ if (startIndex < 0 || startIndex > this.length) {
+ throw new RangeError.range(startIndex, 0, this.length);
+ }
+ return stringReplaceFirstUnchecked(this, from, to, startIndex);
}
List<String> split(Pattern pattern) {

Powered by Google App Engine
This is Rietveld 408576698