Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1210)

Issue 462433002: make it possible to disable the use of libpci on linux again (Closed)

Created:
6 years, 4 months ago by Mostyn Bramley-Moore
Modified:
6 years, 4 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

make it possible to disable the use of libpci on linux again When CL 430573002 landed, it forced the use of libpci on linux, but many embedded systems lack this library (and probably lack a pci bus altogether). Let's add a new config variable to make it possible to disable the use of libpci. BUG=398416 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289262

Patch Set 1 #

Patch Set 2 : attempt to fix the gn build too #

Patch Set 3 : copy out one gyp scope #

Patch Set 4 : include features.gni #

Patch Set 5 : use_x11 and use_ozone can be used to select libpci usage #

Patch Set 6 : document the linux_link_* settings #

Total comments: 2

Patch Set 7 : remove unneeded import #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M build/linux/system.gyp View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/config/BUILD.gn View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M gpu/gpu_config.gypi View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
Mostyn Bramley-Moore
@dnicoara, Zhenyao, piman: how does this small fixup look? (I'm not particularly familiar with gn ...
6 years, 4 months ago (2014-08-11 07:35:56 UTC) #1
dnicoara
I think a bit of code surgery is still required since this is going to ...
6 years, 4 months ago (2014-08-11 13:38:01 UTC) #2
Mostyn Bramley-Moore
On 2014/08/11 13:38:01, dnicoara wrote: > I think a bit of code surgery is still ...
6 years, 4 months ago (2014-08-11 14:17:02 UTC) #3
dnicoara
On 2014/08/11 14:17:02, Mostyn Bramley-Moore wrote: > On 2014/08/11 13:38:01, dnicoara wrote: > > I ...
6 years, 4 months ago (2014-08-11 14:23:21 UTC) #4
Mostyn Bramley-Moore
> I don't know what the original intent of "linux_link_pci" was, but perhaps it > ...
6 years, 4 months ago (2014-08-11 14:31:59 UTC) #5
Mostyn Bramley-Moore
I think I have a simple solution in patchset 5, which makes it possible to ...
6 years, 4 months ago (2014-08-12 14:39:57 UTC) #6
Paweł Hajdan Jr.
Please do NOT remove linux_link_* options.
6 years, 4 months ago (2014-08-12 14:49:38 UTC) #7
Paweł Hajdan Jr.
LGTM
6 years, 4 months ago (2014-08-12 14:49:47 UTC) #8
dnicoara
libpci should be optional for Ozone targets, though I haven't gotten around to figuring out ...
6 years, 4 months ago (2014-08-12 16:12:53 UTC) #9
Mostyn Bramley-Moore
On 2014/08/12 14:49:38, Paweł Hajdan Jr. wrote: > Please do NOT remove linux_link_* options. I ...
6 years, 4 months ago (2014-08-12 18:18:46 UTC) #10
dnicoara
On 2014/08/12 18:18:46, Mostyn Bramley-Moore wrote: > On 2014/08/12 14:49:38, Paweł Hajdan Jr. wrote: > ...
6 years, 4 months ago (2014-08-12 18:52:02 UTC) #11
Zhenyao Mo
I am not gpu/ owner. LGTM anyway.
6 years, 4 months ago (2014-08-12 22:11:26 UTC) #12
Mostyn Bramley-Moore
Ah, right. Adding sievers for gpu/ approval.
6 years, 4 months ago (2014-08-12 22:16:22 UTC) #13
piman
lgtm
6 years, 4 months ago (2014-08-13 05:44:09 UTC) #14
Mostyn Bramley-Moore
The CQ bit was checked by mostynb@opera.com
6 years, 4 months ago (2014-08-13 07:29:46 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/462433002/120001
6 years, 4 months ago (2014-08-13 07:30:35 UTC) #16
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 10:35:43 UTC) #17
Message was sent while issue was closed.
Change committed as 289262

Powered by Google App Engine
This is Rietveld 408576698