Issue 46243003: Docserver: Add an APIModels class which tracks both the list of available APIs

Issue 46243003: Docserver: Add an APIModels class which tracks both the list of available APIs (Closed)

Created:
7 years, 1 month ago by not at google - send to devlin

Modified:
7 years, 1 month ago

Reviewers:
Yoyo Zhou

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Docserver: Add an APIModels class which tracks both the list of available APIs and can return compiled APIs. Not used yet, coming soon. R=yoz@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231963

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : couple more tests #

Total comments: 6

Patch Set 4 : yoz #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+185 lines, -0 lines)			Patch
A	chrome/common/extensions/docs/server2/api_models.py	View	1 2 3	1 chunk	+65 lines, -0 lines	0 comments	Download
A	chrome/common/extensions/docs/server2/api_models_test.py	View	1 2	1 chunk	+114 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/docs/server2/server_instance.py	View		2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Yoyo Zhou

LGTM https://codereview.chromium.org/46243003/diff/50001/chrome/common/extensions/docs/server2/api_models.py File chrome/common/extensions/docs/server2/api_models.py (right): https://codereview.chromium.org/46243003/diff/50001/chrome/common/extensions/docs/server2/api_models.py#newcode36 chrome/common/extensions/docs/server2/api_models.py:36: # Callers sometimes specify a full path (.json ...

7 years, 1 month ago (2013-10-30 23:22:19 UTC) #2

not at google - send to devlin

https://codereview.chromium.org/46243003/diff/50001/chrome/common/extensions/docs/server2/api_models.py File chrome/common/extensions/docs/server2/api_models.py (right): https://codereview.chromium.org/46243003/diff/50001/chrome/common/extensions/docs/server2/api_models.py#newcode36 chrome/common/extensions/docs/server2/api_models.py:36: # Callers sometimes specify a full path (.json or ...

7 years, 1 month ago (2013-10-30 23:50:04 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/46243003/100001

7 years, 1 month ago (2013-10-30 23:59:44 UTC) #4

Message was sent while issue was closed.

Change committed as 231963

Expand Messages | Collapse Messages