chrome/browser/printing/cloud_print/test/cloud_print_policy_browsertest.cc - Issue 462423004: Revert CL 117933003. Re-add resource speculative prefetching code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/cloud_print/test/cloud_print_policy_browsertest.cc

Issue 462423004: Revert CL 117933003. Re-add resource speculative prefetching code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase to fix patch failure Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/predictors/resource_prefetcher_unittest.cc ('k') | chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/cloud_print/test/cloud_print_policy_browsertest.cc

diff --git a/chrome/browser/printing/cloud_print/test/cloud_print_policy_browsertest.cc b/chrome/browser/printing/cloud_print/test/cloud_print_policy_browsertest.cc

index 40fc4b6c20ef8478cf6f158ec55bf687ee75f883..211502c632ae07df529f09254ded13aa8a76e3b4 100644

--- a/chrome/browser/printing/cloud_print/test/cloud_print_policy_browsertest.cc

+++ b/chrome/browser/printing/cloud_print/test/cloud_print_policy_browsertest.cc

@@ -67,6 +67,13 @@ IN_PROC_BROWSER_TEST_F(CloudPrintPolicyTest, NormalPassedFlag) {

IN_PROC_BROWSER_TEST_F(CloudPrintPolicyTest, DISABLED_CloudPrintPolicyFlag) {

CommandLine new_command_line(GetCommandLineForRelaunch());

new_command_line.AppendSwitch(switches::kCheckCloudPrintConnectorPolicy);

+ // This is important for the test as the way the browser process is launched

+ // here causes the predictor databases to be initialized multiple times. This

+ // is not an issue for production where the process is launched as a service

+ // and a Profile is not created. See http://crbug.com/140466 for more details.

+ new_command_line.AppendSwitchASCII(

+ switches::kSpeculativeResourcePrefetching,

+ switches::kSpeculativeResourcePrefetchingDisabled);

base::ProcessHandle handle;

bool launched =