Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 462413003: Move Promise tracking from debug to isolate. (Closed)

Created:
6 years, 4 months ago by Yang
Modified:
6 years, 4 months ago
Reviewers:
aandrey
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Move Promise tracking from debug to isolate. This prepares for tracking promise rejections when debugger is off. R=aandrey@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23101

Patch Set 1 #

Patch Set 2 : move assertions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -92 lines) Patch
M src/debug.h View 4 chunks +0 lines, -29 lines 0 comments Download
M src/debug.cc View 4 chunks +1 line, -56 lines 0 comments Download
M src/isolate.h View 5 chunks +28 lines, -5 lines 0 comments Download
M src/isolate.cc View 1 4 chunks +51 lines, -0 lines 0 comments Download
M src/runtime.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/v8threads.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 4 months ago (2014-08-13 08:33:37 UTC) #1
aandrey
lgtm
6 years, 4 months ago (2014-08-13 10:51:10 UTC) #2
Yang
6 years, 4 months ago (2014-08-13 11:14:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as 23101 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698