Move Location factories and RefactoringProblemSeverity.max into the generated classes.

pkg/analysis_server/tool/spec/codegen_dart_protocol.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library codegen.protocol;
 
 import 'dart:convert';
 
 import 'api.dart';
 import 'codegen_tools.dart';
@@ skipping 343 matching lines @@
         writeln('    elementFromEngine(element);');
         return true;
       case 'ElementKind':
         docComment([new dom.Text(
             'Construct based on a value from the analyzer engine.')]);
         writeln('factory ElementKind.fromEngine(engine.ElementKind kind) =>');
         writeln('    _elementKindFromEngine(kind);');
         return true;
       case 'Location':
         docComment([new dom.Text(
-            'Construct based on an element from the analyzer engine.')]);
+            'Create a Location based on an [engine.Element].')]);
         writeln('factory Location.fromElement(engine.Element element) =>');
         writeln('    _locationFromElement(element);');
         writeln();
-        docComment([new dom.Text('Create a Location based on an element and offset from the analyzer engine.')]);
-        writeln('factory Location.fromOffset(engine.Element element, int offset, int length) =>');
-        writeln('    _locationFromOffset(element, offset, length);');
+        docComment([new dom.Text('Create a Location based on an [engine.SearchMatch].')]);
+        writeln('factory Location.fromMatch(engine.SearchMatch match) =>');
+        writeln('    _locationFromMatch(match);');
+        writeln();
+        docComment([new dom.Text('Create a Location based on an [engine.AstNode].')]);
+        writeln('factory Location.fromNode(engine.AstNode node) =>');
+        writeln('    _locationFromNode(node);');
+        writeln();
+        docComment([new dom.Text('Create a Location based on an [engine.CompilationUnit].')]);
+        writeln('factory Location.fromUnit(engine.CompilationUnit unit, engine.SourceRange range) =>');
+        writeln('    _locationFromUnit(unit, range);');
         return true;
       case 'OverriddenMember':
         docComment([new dom.Text('Construct based on an element from the analyzer engine.')]);
         writeln('factory OverriddenMember.fromEngine(engine.Element member) =>');
         writeln('    _overriddenMemberFromEngine(member);');
         return true;
+      case 'RefactoringProblemSeverity':
+        docComment([new dom.Text('Returns the [RefactoringProblemSeverity] with the maximal severity.')]);
+        writeln('static RefactoringProblemSeverity max(RefactoringProblemSeverity a, RefactoringProblemSeverity b) =>');
+        writeln('    _maxRefactoringProblemSeverity(a, b);');
+        return true;
       case 'SearchResult':
         docComment([new dom.Text('Construct based on a value from the search engine.')]);
         writeln('factory SearchResult.fromMatch(engine.SearchMatch match) =>');
         writeln('    searchResultFromMatch(match);');
         return true;
       case 'SearchResultKind':
         docComment([new dom.Text('Construct based on a value from the search engine.')]);
         writeln('factory SearchResultKind.fromEngine(engine.MatchKind kind) =>');
         writeln('    _searchResultKindFromEngine(kind);');
         return true;
@@ skipping 646 matching lines @@
   CodegenProtocolVisitor visitor = new CodegenProtocolVisitor(readApi());
   return visitor.collectCode(visitor.visitApi);
 });
 
 /**
  * Translate spec_input.html into protocol_matchers.dart.
  */
 main() {
   target.generate();
 }