Move Location factories and RefactoringProblemSeverity.max into the generated classes.

pkg/analysis_server/lib/src/services/refactoring/rename_local.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.src.refactoring.rename_local;
 
 import 'dart:async';
 
+import 'package:analysis_server/src/protocol2.dart' show Location;
 import 'package:analysis_server/src/services/correction/change.dart';
 import 'package:analysis_server/src/services/correction/status.dart';
+import 'package:analysis_server/src/services/correction/util.dart';
+import 'package:analysis_server/src/services/refactoring/naming_conventions.dart';
 import 'package:analysis_server/src/services/refactoring/refactoring.dart';
+import 'package:analysis_server/src/services/refactoring/rename.dart';
 import 'package:analysis_server/src/services/search/hierarchy.dart';
 import 'package:analysis_server/src/services/search/search_engine.dart';
-import 'package:analysis_server/src/services/correction/util.dart';
-import 'package:analysis_server/src/services/refactoring/naming_conventions.dart';
-import 'package:analysis_server/src/services/refactoring/rename.dart';
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:analyzer/src/generated/element.dart';
 import 'package:analyzer/src/generated/source.dart';
 
 
 /**
  * A [Refactoring] for renaming [LocalElement]s.
  */
 class RenameLocalRefactoringImpl extends RenameRefactoringImpl {
   RenameLocalRefactoringImpl(SearchEngine searchEngine, LocalElement element)
@@ skipping 85 matching lines @@
 
   @override
   Object visitSimpleIdentifier(SimpleIdentifier node) {
     Element nodeElement = node.bestElement;
     String newName = refactoring.newName;
     if (nodeElement != null && nodeElement.name == newName) {
       // duplicate declaration
       if (haveIntersectingRanges(refactoring.element, nodeElement)) {
         String nodeKind = nodeElement.kind.displayName;
         String message = "Duplicate ${nodeKind} '$newName'.";
-        result.addError(
-            message,
-            createLocation_forElement(nodeElement));
+        result.addError(message, new Location.fromElement(nodeElement));
         return null;
       }
       // shadowing referenced element
       if (elementRange.contains(node.offset) && !node.isQualified) {
         nodeElement = getSyntheticAccessorVariable(nodeElement);
         String nodeKind = nodeElement.kind.displayName;
         String nodeName = getElementQualifiedName(nodeElement);
         String nameElementSourceName = nodeElement.source.shortName;
         String refKind = refactoring.element.kind.displayName;
         String message =
             'Usage of $nodeKind "$nodeName" declared in '
                 '"$nameElementSourceName" will be shadowed by renamed $refKind.';
-        result.addError(message, createLocation_forNode(node));
+        result.addError(message, new Location.fromNode(node));
       }
     }
     return null;
   }
 }