Move Location factories and RefactoringProblemSeverity.max into the generated classes.

pkg/analysis_server/test/services/correction/status_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.services.correction.status;
 
 import 'package:analysis_server/src/services/correction/status.dart';
 import 'package:analysis_server/src/services/search/search_engine.dart';
 import 'package:analysis_server/src/services/correction/source_range.dart';
 import 'package:analysis_testing/abstract_single_unit.dart';
@@ skipping 12 matching lines @@
   runReflectiveTests(RefactoringStatusTest);
 }
 
 
 @ReflectiveTestCase()
 class RefactoringLocationTest extends AbstractSingleUnitTest {
   void test_createLocation_forElement() {
     resolveTestUnit('class MyClass {}');
     Element element = findElement('MyClass');
     // check
-    Location location = createLocation_forElement(element);
+    Location location = new Location.forElement(element);
     expect(location.file, '/test.dart');
     expect(location.offset, 6);
     expect(location.length, 7);
     expect(location.startLine, 1);
     expect(location.startColumn, 7);
   }
 
   void test_createLocation_forMatch() {
     resolveTestUnit('class MyClass {}');
     Element element = findElement('MyClass');
     SourceRange range = rangeElementName(element);
     SearchMatch match = new SearchMatch(null, element, range, true, false);
     // check
-    Location location = createLocation_forMatch(match);
+    Location location = new Location.forMatch(match);
     expect(location.file, '/test.dart');
     expect(location.offset, range.offset);
     expect(location.length, range.length);
   }
 
   void test_createLocation_forNode() {
     resolveTestUnit('''
 main() {
 }
 ''');
     AstNode node = findNodeAtString('main');
     // check
-    Location location = createLocation_forNode(node);
+    Location location = new Location.forNode(node);
     expect(location.file, '/test.dart');
     expect(location.offset, node.offset);
     expect(location.length, node.length);
   }
 
   void test_createLocation_forUnit() {
     resolveTestUnit('');
     SourceRange range = rangeStartLength(10, 20);
     // check
-    Location location = createLocation_forUnit(testUnit, range);
+    Location location = new Location.forUnit(testUnit, range);
     expect(location.file, '/test.dart');
     expect(location.offset, range.offset);
     expect(location.length, range.length);
   }
 }
 
 
 @ReflectiveTestCase()
 class RefactoringStatusTest {
   void test_addError() {
@@ skipping 139 matching lines @@
     expect(refactoringStatus.severity, RefactoringProblemSeverity.FATAL);
     expect(refactoringStatus.message, 'msg');
   }
 
   void test_newWarning() {
     RefactoringStatus refactoringStatus = new RefactoringStatus.warning('msg');
     expect(refactoringStatus.severity, RefactoringProblemSeverity.WARNING);
     expect(refactoringStatus.message, 'msg');
   }
 }