Move Location factories and RefactoringProblemSeverity.max into the generated classes.

pkg/analysis_server/lib/src/services/refactoring/rename_unit_member.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.src.refactoring.rename_unit_member;
 
 import 'dart:async';
 
+import 'package:analysis_server/src/protocol2.dart' show Location;
 import 'package:analysis_server/src/services/correction/change.dart';
 import 'package:analysis_server/src/services/correction/status.dart';
-import 'package:analysis_server/src/services/refactoring/refactoring.dart';
-import 'package:analysis_server/src/services/search/search_engine.dart';
 import 'package:analysis_server/src/services/correction/util.dart';
 import 'package:analysis_server/src/services/refactoring/naming_conventions.dart';
+import 'package:analysis_server/src/services/refactoring/refactoring.dart';
 import 'package:analysis_server/src/services/refactoring/rename.dart';
+import 'package:analysis_server/src/services/search/element_visitors.dart';
+import 'package:analysis_server/src/services/search/search_engine.dart';
 import 'package:analyzer/src/generated/element.dart';
 import 'package:analyzer/src/generated/java_core.dart';
-import 'package:analysis_server/src/services/search/element_visitors.dart';
 
 
 /**
  * A [Refactoring] for renaming compilation unit member [Element]s.
  */
 class RenameUnitMemberRefactoringImpl extends RenameRefactoringImpl {
   RenameUnitMemberRefactoringImpl(SearchEngine searchEngine, Element element)
       : super(searchEngine, element);
 
   @override
@@ skipping 135 matching lines @@
    */
   Future _validateWillBeShadowed() {
     return searchEngine.searchReferences(element).then((references) {
       for (SearchMatch reference in references) {
         Element refElement = reference.element;
         ClassElement refClass =
             refElement.getAncestor((e) => e is ClassElement);
         if (refClass != null) {
           visitChildren(refClass, (shadow) {
             if (hasDisplayName(shadow, newName)) {
-              String message =
-                  format(
-                      "Reference to renamed {0} will be shadowed by {1} '{2}'.",
-                      getElementKindName(element),
-                      getElementKindName(shadow),
-                      getElementQualifiedName(shadow));
-              result.addError(
-                  message,
-                  createLocation_forElement(shadow));
+              String message = format(
+                  "Reference to renamed {0} will be shadowed by {1} '{2}'.",
+                  getElementKindName(element),
+                  getElementKindName(shadow),
+                  getElementQualifiedName(shadow));
+              result.addError(message, new Location.forElement(shadow));
             }
           });
         }
       }
     });
   }
 
   /**
    * Validates if [element] renamed to [newName] will conflict with another
    * top-level [Element] in the same library.
    */
   void _validateWillConflict() {
     LibraryElement library = element.getAncestor((e) => e is LibraryElement);
     visitLibraryTopLevelElements(library, (element) {
       if (hasDisplayName(element, newName)) {
-        String message =
-            format(
-                "Library already declares {0} with name '{1}'.",
-                getElementKindName(element),
-                newName);
-        result.addError(
-            message,
-            createLocation_forElement(element));
+        String message = format(
+            "Library already declares {0} with name '{1}'.",
+            getElementKindName(element),
+            newName);
+        result.addError(message, new Location.forElement(element));
       }
     });
   }
 
   /**
    * Validates if renamed [element] will shadow any [Element] named [newName].
    */
   Future _validateWillShadow() {
     return searchEngine.searchMemberDeclarations(newName).then((declarations) {
       return Future.forEach(declarations, (SearchMatch declaration) {
@@ skipping 10 matching lines @@
             ClassElement refClass =
                 refElement.getAncestor((e) => e is ClassElement);
             if (refClass == declaringClass) {
               continue;
             }
             // ignore if not visitble
             if (!_isVisibleAt(element, memberReference)) {
               continue;
             }
             // OK, reference will be shadowed be the element being renamed
-            String message =
-                format(
-                    forRename ?
-                        "Renamed {0} will shadow {1} '{2}'." :
-                        "Created {0} will shadow {1} '{2}'.",
-                    getElementKindName(element),
-                    getElementKindName(member),
-                    getElementQualifiedName(member));
-            result.addError(
-                message,
-                createLocation_forMatch(memberReference));
+            String message = format(
+                forRename ?
+                    "Renamed {0} will shadow {1} '{2}'." :
+                    "Created {0} will shadow {1} '{2}'.",
+                getElementKindName(element),
+                getElementKindName(member),
+                getElementQualifiedName(member));
+            result.addError(message, new Location.forMatch(memberReference));
           }
         });
       });
     });
   }
 }