Issue 462383003: Remove the check for loading component IME extensions.

Issue 462383003: Remove the check for loading component IME extensions. (Closed)

Created:
6 years, 4 months ago by Shu Chen

Modified:
6 years, 4 months ago

Reviewers:
sky, Seigo Nonaka

CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove the check for loading component IME extensions. After below CLs, the check is unnecessary, because for linux_chromeos, if no extension background pages, key events won't be blocked by IMF. https://codereview.chromium.org/433163005/ https://codereview.chromium.org/444523003/ BUG=None TEST=Verified on linux_chromeos. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289566

Patch Set 1 #

Patch Set 2 : avoid loading extensions for browser tests. #

Patch Set 3 : fixed unit_tests compiling error. #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 2

Patch Set 6 : nit. #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -16 lines)			Patch
M	chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_configuration.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_configuration.cc	View	1	3 chunks	+8 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_manager_impl.h	View	1	2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_manager_impl.cc	View	1	2 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/base/in_process_browser_test.cc	View	1 2 3 4 5	2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/462383003/diff/80001/chrome/test/base/in_process_browser_test.cc File chrome/test/base/in_process_browser_test.cc (right): https://codereview.chromium.org/462383003/diff/80001/chrome/test/base/in_process_browser_test.cc#newcode183 chrome/test/base/in_process_browser_test.cc:183: chromeos::input_method::DisableExtensionLoading(); Please document why this is necessary.

6 years, 4 months ago (2014-08-13 16:55:56 UTC) #3

Shu Chen

https://codereview.chromium.org/462383003/diff/80001/chrome/test/base/in_process_browser_test.cc File chrome/test/base/in_process_browser_test.cc (right): https://codereview.chromium.org/462383003/diff/80001/chrome/test/base/in_process_browser_test.cc#newcode183 chrome/test/base/in_process_browser_test.cc:183: chromeos::input_method::DisableExtensionLoading(); On 2014/08/13 16:55:56, sky wrote: > Please document ...

6 years, 4 months ago (2014-08-14 00:51:22 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/462383003/2

6 years, 4 months ago (2014-08-14 00:55:28 UTC) #7

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...

6 years, 4 months ago (2014-08-14 13:27:15 UTC) #8

Message was sent while issue was closed.

Committed patchset #6 (2) as 289566

Expand Messages | Collapse Messages