Do not run header include order checks on blacklisted files

Do not run header include order checks on blacklisted files

The header include order checks were running on all
affected files, including third_party for example,
this causes issues when rolling harfbuzz-ng.

BUG=404105
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289968

[Nico, 2014-08-15 18:25:59]

Looks fine (with comment), but why does this help with harfbuzz? How does this
get excluded by these filters?

https://codereview.chromium.org/462323003/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/462323003/diff/1/PRESUBMIT.py#newcode723
PRESUBMIT.py:723: _TEST_CODE_EXCLUDED_PATHS +
This one doesn't look right. We care about include order in our test code.

[Nico, 2014-08-15 18:28:54]

Ah, DEFAULT_BLACK_LIST excludes third_party:
https://code.google.com/p/chromium/codesearch#chromium/tools/depot_tools/pres...

I think it's fair game to exclude your code from presubmit if you add your
first-party code below third_party, so this lgtm with the TEST_CODE… line
removed.

[Nico, 2014-08-15 18:29:00]

…and thanks!

[Dominik Röttsches, 2014-08-15 18:32:56]

The CQ bit was checked by dominik.rottsches@intel.com

[commit-bot: I haz the power, 2014-08-15 18:36:57]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/dominik.rottsches@intel.com/462323003/...

[M-A Ruel, 2014-08-15 18:50:30]

lgtm, thanks for the fix but add NOTRY=true.

https://codereview.chromium.org/462323003/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/462323003/diff/20001/PRESUBMIT.py#newcode722
PRESUBMIT.py:722: black_list = (_EXCLUDED_PATHS +
it fits 80 cols?

https://codereview.chromium.org/462323003/diff/20001/PRESUBMIT.py#newcode725
PRESUBMIT.py:725: affected_file,
fit 80 cols? Otherwise align at +4.

[Dominik Röttsches, 2014-08-15 18:57:51]

The CQ bit was checked by dominik.rottsches@intel.com

[commit-bot: I haz the power, 2014-08-15 18:58:21]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/dominik.rottsches@intel.com/462323003/...

[commit-bot: I haz the power, 2014-08-15 19:08:43]

Committed patchset #3 (40001) as 289968