Add a clearSelection method to ContentViewCore.java.

Add a clearSelection method to ContentViewCore.java.

BUG=396738
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289177

[Donn Denman, 2014-08-12 23:33:49]

Jared, PTAL.  Thanks!

[jdduke (slow), 2014-08-12 23:47:19]

https://chromiumcodereview.appspot.com/462313002/diff/1/content/public/androi...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://chromiumcodereview.appspot.com/462313002/diff/1/content/public/androi...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:2132:
public boolean clearSelection() {
Does the boolean result add anything here? I think we only return false if
ImeAdapter has no native interface. If you don't plan on using the result
meaningfully we should just use void.

[Donn Denman, 2014-08-12 23:53:03]

PTAL, thanks!

https://chromiumcodereview.appspot.com/462313002/diff/1/content/public/androi...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://chromiumcodereview.appspot.com/462313002/diff/1/content/public/androi...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:2132:
public boolean clearSelection() {
On 2014/08/12 23:47:19, jdduke wrote:
> Does the boolean result add anything here? I think we only return false if
> ImeAdapter has no native interface. If you don't plan on using the result
> meaningfully we should just use void.

I wondered how common it would be for it to lack a native interface, but agree
it's better to remove that if uncommon and not needed.

Done.

[jdduke (slow), 2014-08-12 23:55:49]

lgtm

[Donn Denman, 2014-08-12 23:59:16]

The CQ bit was checked by donnd@chromium.org

[commit-bot: I haz the power, 2014-08-13 00:18:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/donnd@chromium.org/462313002/20001

[commit-bot: I haz the power, 2014-08-13 03:14:17]

Change committed as 289177