Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 462273003: Show extension name for dependent extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: feedback Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/extensions/extensions.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
index e8c5110ce1d4c78a4a7f1e1aa0129c686ef1ff3e..abdb9529f51570fbd8e6b002e6ebcf8c73f9ec44 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
@@ -276,7 +276,10 @@ base::DictionaryValue* ExtensionSettingsHandler::CreateExtensionDetailValue(
for (ExtensionSet::const_iterator i = dependent_extensions->begin();
i != dependent_extensions->end();
i++) {
- dependents_list->Append(new base::StringValue((*i)->id()));
+ base::DictionaryValue* dependent_entry = new base::DictionaryValue;
+ dependent_entry->SetString("id", (*i)->id());
+ dependent_entry->SetString("name", (*i)->name());
+ dependents_list->Append(dependent_entry);
}
}
extension_data->Set("dependentExtensions", dependents_list);
« no previous file with comments | « chrome/browser/resources/extensions/extensions.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698