Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6828)

Unified Diff: chrome/browser/resources/extensions/extension_list.js

Issue 462273003: Show extension name for dependent extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: feedback Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/extensions/extensions.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/extensions/extension_list.js
diff --git a/chrome/browser/resources/extensions/extension_list.js b/chrome/browser/resources/extensions/extension_list.js
index 7067da5d00362dd398a95e914e17ca357a3a74ea..1271b28de19ca8a14fa504ed02fdbd347d26d167 100644
--- a/chrome/browser/resources/extensions/extension_list.js
+++ b/chrome/browser/resources/extensions/extension_list.js
@@ -321,10 +321,13 @@ cr.define('options', function() {
node.querySelector('.dependent-extensions-message');
dependentMessage.hidden = false;
var dependentList = dependentMessage.querySelector('ul');
- extension.dependentExtensions.forEach(function(id) {
- var li = document.createElement('li');
- li.innerText = id;
- dependentList.appendChild(li);
+ var dependentTemplate = $('template-collection').querySelector(
+ '.dependent-list-item');
+ extension.dependentExtensions.forEach(function(elem) {
+ var depNode = dependentTemplate.cloneNode(true);
+ depNode.querySelector('.dep-extension-title').textContent = elem.name;
+ depNode.querySelector('.dep-extension-id').textContent = elem.id;
+ dependentList.appendChild(depNode);
});
}
« no previous file with comments | « no previous file | chrome/browser/resources/extensions/extensions.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698