Chromium Code Reviews| Index: chrome/browser/resources/extensions/extension_list.js |
| diff --git a/chrome/browser/resources/extensions/extension_list.js b/chrome/browser/resources/extensions/extension_list.js |
| index 7067da5d00362dd398a95e914e17ca357a3a74ea..973ec581ecbc2c9c7f5ec1e56b183ec3ea7347ea 100644 |
| --- a/chrome/browser/resources/extensions/extension_list.js |
| +++ b/chrome/browser/resources/extensions/extension_list.js |
| @@ -321,10 +321,15 @@ cr.define('options', function() { |
| node.querySelector('.dependent-extensions-message'); |
| dependentMessage.hidden = false; |
| var dependentList = dependentMessage.querySelector('ul'); |
| - extension.dependentExtensions.forEach(function(id) { |
| - var li = document.createElement('li'); |
| - li.innerText = id; |
| - dependentList.appendChild(li); |
| + extension.dependentExtensions.forEach(function(elem) { |
| + var dependentTemplate = $('template-dependent').querySelector( |
| + '.dependent-list-item'); |
|
not at google - send to devlin
2014/08/13 19:43:47
Save this outside the forEach loop?
elijahtaylor1
2014/08/13 21:12:45
Done.
|
| + var dependentNode = dependentTemplate.cloneNode(true); |
| + var dependentTitle = dependentNode.querySelector('.extension-title'); |
| + dependentTitle.textContent = elem.name; |
|
not at google - send to devlin
2014/08/13 19:43:47
Nit: to save on the saturation of "dependent*" var
elijahtaylor1
2014/08/13 21:12:45
Done.
|
| + var dependentId = dependentNode.querySelector('.extension-id'); |
| + dependentId.textContent = elem.id; |
| + dependentList.appendChild(dependentNode); |
| }); |
| } |