Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: chrome/browser/resources/extensions/extension_list.js

Issue 462273003: Show extension name for dependent extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/extensions/extension_settings_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/extensions/extension_list.js
diff --git a/chrome/browser/resources/extensions/extension_list.js b/chrome/browser/resources/extensions/extension_list.js
index 7067da5d00362dd398a95e914e17ca357a3a74ea..8627d68a2341db0f740fb0a7e03e0dd447be739e 100644
--- a/chrome/browser/resources/extensions/extension_list.js
+++ b/chrome/browser/resources/extensions/extension_list.js
@@ -321,9 +321,15 @@ cr.define('options', function() {
node.querySelector('.dependent-extensions-message');
dependentMessage.hidden = false;
var dependentList = dependentMessage.querySelector('ul');
- extension.dependentExtensions.forEach(function(id) {
+ extension.dependentExtensions.forEach(function(elem) {
var li = document.createElement('li');
- li.innerText = id;
+ var nameSpan = document.createElement('span');
+ var idSpan = document.createElement('span');
+ nameSpan.innerText = elem.name;
+ idSpan.innerText = ' (' + elem.id + ')';
not at google - send to devlin 2014/08/13 01:42:31 You should use .textContent not .innerText. Anyho
elijahtaylor1 2014/08/13 18:02:59 great, a template is what I was looking for (inste
+ idSpan.className = 'developer-extras';
+ li.appendChild(nameSpan);
+ li.appendChild(idSpan);
dependentList.appendChild(li);
});
}
« no previous file with comments | « no previous file | chrome/browser/ui/webui/extensions/extension_settings_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698