chrome/browser/resources/extensions/extensions.html - Issue 462273003: Show extension name for dependent extensions

Side by Side Diff: chrome/browser/resources/extensions/extensions.html

Issue 462273003: Show extension name for dependent extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: use template Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/resources/extensions/extension_list.js ('K') | « chrome/browser/resources/extensions/extension_list.js ('k') | chrome/browser/ui/webui/extensions/extension_settings_handler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html i18n-values="dir:textdirection;" class="loading">	2 <html i18n-values="dir:textdirection;" class="loading">

3 <head>	3 <head>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5	5

6 <link rel="stylesheet" href="extensions.css">	6 <link rel="stylesheet" href="extensions.css">

7 <link rel="stylesheet" href="extension_commands_overlay.css">	7 <link rel="stylesheet" href="extension_commands_overlay.css">

8 <link rel="stylesheet" href="extension_error.css">	8 <link rel="stylesheet" href="extension_error.css">

9 <link rel="stylesheet" href="extension_error_overlay.css">	9 <link rel="stylesheet" href="extension_error_overlay.css">

10 <link rel="stylesheet" href="extension_load_error.css">	10 <link rel="stylesheet" href="extension_load_error.css">

(...skipping 234 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
245 </div>	245 </div>

246 </div>	246 </div>

247 </div>	247 </div>

248 </div>	248 </div>

249	249

250 <include src="../../../../ui/webui/resources/html/trash.html">	250 <include src="../../../../ui/webui/resources/html/trash.html">

251 <include src="extension_error.html">	251 <include src="extension_error.html">

252	252

253 </div>	253 </div>

254	254

	255 <div id="template-dependent" hidden>
	not at google - send to devlin 2014/08/13 19:43:47 I'm not at all familiar with the idioms of this fi I'm not at all familiar with the idioms of this file, but it does look like the other templates are declared inside that template-collection <div>. elijahtaylor1 2014/08/13 21:12:46 Done. Show quoted text On 2014/08/13 19:43:47, kalman wrote: > I'm not at all familiar with the idioms of this file, but it does look like the > other templates are declared inside that template-collection <div>. Done.
	256 <li class="dependent-list-item">
	elijahtaylor1 2014/08/13 18:02:59 I wasn't sure if I should continue to use <li> or I wasn't sure if I should continue to use <li> or not, the other "list" is just a series of divs, but I'm actually using an <ul> not at google - send to devlin 2014/08/13 19:43:47 <li> looks right, but having <divs> inside <li> is Show quoted text On 2014/08/13 18:02:59, elijahtaylor1 wrote: > I wasn't sure if I should continue to use <li> or not, the other "list" is just > a series of divs, but I'm actually using an <ul> <li> looks right, but having <divs> inside <li> is odd since div is a block and li is a line. Use <span> instead? elijahtaylor1 2014/08/13 21:12:46 I got rid of the divs and used an embedded <ul> to Show quoted text On 2014/08/13 19:43:47, kalman wrote: > On 2014/08/13 18:02:59, elijahtaylor1 wrote: > > I wasn't sure if I should continue to use <li> or not, the other "list" is > just > > a series of divs, but I'm actually using an <ul> > > <li> looks right, but having <divs> inside <li> is odd since div is a block and > li is a line. Use <span> instead? I got rid of the divs and used an embedded <ul> to deal with displaying the ID (and potentially other developer mode data eventually)
	257 <div>

	258 <span class="extension-title"></span>

	259 </div>

	260 <div class="developer-extras">

	261 <div>

	262 <span i18n-content="extensionSettingsExtensionId"></span>

	263 <span class="extension-id"></span>

	264 </div>

	265 </div>

	266 </li>

	267 </div>

	268

255 <script src="chrome://extensions-frame/strings.js"></script>	269 <script src="chrome://extensions-frame/strings.js"></script>

256 <script src="chrome://resources/js/i18n_template2.js"></script>	270 <script src="chrome://resources/js/i18n_template2.js"></script>

257	271

258 </body>	272 </body>

259 </html>	273 </html>

OLD	NEW