Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Side by Side Diff: chrome/browser/resources/extensions/extension_list.js

Issue 462273003: Show extension name for dependent extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: use template Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 <include src="extension_error.js"> 5 <include src="extension_error.js">
6 6
7 cr.define('options', function() { 7 cr.define('options', function() {
8 'use strict'; 8 'use strict';
9 9
10 /** 10 /**
(...skipping 303 matching lines...) Expand 10 before | Expand all | Expand 10 after
314 // Then the 'This is a corrupt extension' message. 314 // Then the 'This is a corrupt extension' message.
315 node.querySelector('.corrupt-install-message').hidden = false; 315 node.querySelector('.corrupt-install-message').hidden = false;
316 } 316 }
317 } 317 }
318 318
319 if (extension.dependentExtensions.length > 0) { 319 if (extension.dependentExtensions.length > 0) {
320 var dependentMessage = 320 var dependentMessage =
321 node.querySelector('.dependent-extensions-message'); 321 node.querySelector('.dependent-extensions-message');
322 dependentMessage.hidden = false; 322 dependentMessage.hidden = false;
323 var dependentList = dependentMessage.querySelector('ul'); 323 var dependentList = dependentMessage.querySelector('ul');
324 extension.dependentExtensions.forEach(function(id) { 324 extension.dependentExtensions.forEach(function(elem) {
325 var li = document.createElement('li'); 325 var dependentTemplate = $('template-dependent').querySelector(
326 li.innerText = id; 326 '.dependent-list-item');
not at google - send to devlin 2014/08/13 19:43:47 Save this outside the forEach loop?
elijahtaylor1 2014/08/13 21:12:45 Done.
327 dependentList.appendChild(li); 327 var dependentNode = dependentTemplate.cloneNode(true);
328 var dependentTitle = dependentNode.querySelector('.extension-title');
329 dependentTitle.textContent = elem.name;
not at google - send to devlin 2014/08/13 19:43:47 Nit: to save on the saturation of "dependent*" var
elijahtaylor1 2014/08/13 21:12:45 Done.
330 var dependentId = dependentNode.querySelector('.extension-id');
331 dependentId.textContent = elem.id;
332 dependentList.appendChild(dependentNode);
328 }); 333 });
329 } 334 }
330 335
331 // Then active views. 336 // Then active views.
332 if (extension.views.length > 0) { 337 if (extension.views.length > 0) {
333 var activeViews = node.querySelector('.active-views'); 338 var activeViews = node.querySelector('.active-views');
334 activeViews.hidden = false; 339 activeViews.hidden = false;
335 var link = activeViews.querySelector('a'); 340 var link = activeViews.querySelector('a');
336 341
337 extension.views.forEach(function(view, i) { 342 extension.views.forEach(function(view, i) {
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
406 topScroll -= pad / 2; 411 topScroll -= pad / 2;
407 setScrollTopForDocument(document, topScroll); 412 setScrollTopForDocument(document, topScroll);
408 } 413 }
409 }, 414 },
410 }; 415 };
411 416
412 return { 417 return {
413 ExtensionsList: ExtensionsList 418 ExtensionsList: ExtensionsList
414 }; 419 };
415 }); 420 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698