Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Side by Side Diff: chrome/browser/resources/extensions/extension_list.js

Issue 462273003: Show extension name for dependent extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/ui/webui/extensions/extension_settings_handler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 <include src="extension_error.js"> 5 <include src="extension_error.js">
6 6
7 cr.define('options', function() { 7 cr.define('options', function() {
8 'use strict'; 8 'use strict';
9 9
10 /** 10 /**
(...skipping 303 matching lines...) Expand 10 before | Expand all | Expand 10 after
314 // Then the 'This is a corrupt extension' message. 314 // Then the 'This is a corrupt extension' message.
315 node.querySelector('.corrupt-install-message').hidden = false; 315 node.querySelector('.corrupt-install-message').hidden = false;
316 } 316 }
317 } 317 }
318 318
319 if (extension.dependentExtensions.length > 0) { 319 if (extension.dependentExtensions.length > 0) {
320 var dependentMessage = 320 var dependentMessage =
321 node.querySelector('.dependent-extensions-message'); 321 node.querySelector('.dependent-extensions-message');
322 dependentMessage.hidden = false; 322 dependentMessage.hidden = false;
323 var dependentList = dependentMessage.querySelector('ul'); 323 var dependentList = dependentMessage.querySelector('ul');
324 extension.dependentExtensions.forEach(function(id) { 324 extension.dependentExtensions.forEach(function(elem) {
325 var li = document.createElement('li'); 325 var li = document.createElement('li');
326 li.innerText = id; 326 var nameSpan = document.createElement('span');
327 var idSpan = document.createElement('span');
328 nameSpan.innerText = elem.name;
329 idSpan.innerText = ' (' + elem.id + ')';
not at google - send to devlin 2014/08/13 01:42:31 You should use .textContent not .innerText. Anyho
elijahtaylor1 2014/08/13 18:02:59 great, a template is what I was looking for (inste
330 idSpan.className = 'developer-extras';
331 li.appendChild(nameSpan);
332 li.appendChild(idSpan);
327 dependentList.appendChild(li); 333 dependentList.appendChild(li);
328 }); 334 });
329 } 335 }
330 336
331 // Then active views. 337 // Then active views.
332 if (extension.views.length > 0) { 338 if (extension.views.length > 0) {
333 var activeViews = node.querySelector('.active-views'); 339 var activeViews = node.querySelector('.active-views');
334 activeViews.hidden = false; 340 activeViews.hidden = false;
335 var link = activeViews.querySelector('a'); 341 var link = activeViews.querySelector('a');
336 342
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
406 topScroll -= pad / 2; 412 topScroll -= pad / 2;
407 setScrollTopForDocument(document, topScroll); 413 setScrollTopForDocument(document, topScroll);
408 } 414 }
409 }, 415 },
410 }; 416 };
411 417
412 return { 418 return {
413 ExtensionsList: ExtensionsList 419 ExtensionsList: ExtensionsList
414 }; 420 };
415 }); 421 });
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/webui/extensions/extension_settings_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698