Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: LayoutTests/fullscreen/full-screen-remove-ancestor.html

Issue 462253003: Remove early returns in fullscreen tests (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fullscreen/full-screen-remove-ancestor.html
diff --git a/LayoutTests/fullscreen/full-screen-remove-ancestor.html b/LayoutTests/fullscreen/full-screen-remove-ancestor.html
index 26f4ed75540ac16b1af2527425dae4031f744337..bb0bbfdae62cad0d1376280132b22b58319e9864 100644
--- a/LayoutTests/fullscreen/full-screen-remove-ancestor.html
+++ b/LayoutTests/fullscreen/full-screen-remove-ancestor.html
@@ -2,35 +2,29 @@
<script src="full-screen-test.js"></script>
<div><span></span></div>
<script>
- // Bail out early if the full screen API is not enabled or is missing:
- if (Element.prototype.webkitRequestFullScreen == undefined) {
- logResult(false, "Element.prototype.webkitRequestFullScreen == undefined");
- endTest();
- } else {
- var callback;
- var fullscreenChanged = function(event)
- {
- if (callback)
- callback(event)
- };
- waitForEvent(document, 'webkitfullscreenchange', fullscreenChanged);
+ var callback;
+ var fullscreenChanged = function(event)
+ {
+ if (callback)
+ callback(event)
+ };
+ waitForEvent(document, 'webkitfullscreenchange', fullscreenChanged);
- var span = document.getElementsByTagName('span')[0];
- var div = span.parentNode;
+ var span = document.getElementsByTagName('span')[0];
+ var div = span.parentNode;
- var spanEnteredFullScreen = function(event) {
- callback = spanExitedFullScreen;
- testExpected("document.webkitCurrentFullScreenElement", span);
- document.body.removeChild(div);
- };
+ var spanEnteredFullScreen = function(event) {
+ callback = spanExitedFullScreen;
+ testExpected("document.webkitCurrentFullScreenElement", span);
+ document.body.removeChild(div);
+ };
- var spanExitedFullScreen = function(event) {
- callback = null;
- testExpected("document.webkitCurrentFullScreenElement", null);
- endTest();
- };
+ var spanExitedFullScreen = function(event) {
+ callback = null;
+ testExpected("document.webkitCurrentFullScreenElement", null);
+ endTest();
+ };
- callback = spanEnteredFullScreen;
- runWithKeyDown(function(){span.webkitRequestFullScreen()});
- }
+ callback = spanEnteredFullScreen;
+ runWithKeyDown(function(){span.webkitRequestFullScreen()});
</script>
« no previous file with comments | « LayoutTests/fullscreen/full-screen-remove.html ('k') | LayoutTests/fullscreen/full-screen-remove-ancestor-after.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698