Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: LayoutTests/fullscreen/full-screen-keyboard-disabled.html

Issue 462253003: Remove early returns in fullscreen tests (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fullscreen/full-screen-keyboard-disabled.html
diff --git a/LayoutTests/fullscreen/full-screen-keyboard-disabled.html b/LayoutTests/fullscreen/full-screen-keyboard-disabled.html
index f82b9b879b287375bc1377395faac26049a69809..8d6ed140a44bd196815fa8d075ffff6c21b78679 100644
--- a/LayoutTests/fullscreen/full-screen-keyboard-disabled.html
+++ b/LayoutTests/fullscreen/full-screen-keyboard-disabled.html
@@ -3,38 +3,32 @@
<p>This tests that full screen mode does not allow alphanumeric key events. Press space to continue, then press an alphanumeric key, followed by space.
<span></span>
<script>
- // Bail out early if the full screen API is not enabled or is missing:
- if (Element.prototype.webkitRequestFullScreen == undefined) {
- logResult(false, "Element.prototype.webkitRequestFullScreen == undefined");
- endTest();
- } else {
- var callback;
- var fullscreenChanged = function(event)
- {
- if (callback)
- callback(event)
- };
- waitForEvent(document, 'webkitfullscreenchange', fullscreenChanged);
-
- var spanEnteredFullScreen = function() {
- callback = null;
- testExpected("document.webkitIsFullScreen", true);
- if (window.testRunner && eventSender.keyDown) {
- waitForEvent(document, 'keypress', keyPressed);
- eventSender.keyDown('a', []);
- eventSender.keyDown(' ', []);
- }
- };
+ var callback;
+ var fullscreenChanged = function(event)
+ {
+ if (callback)
+ callback(event)
+ };
+ waitForEvent(document, 'webkitfullscreenchange', fullscreenChanged);
- var keyPressed = function(event) {
- testExpected('event.keyCode', 32); // Space
- endTest();
- document.webkitCancelFullScreen();
+ var spanEnteredFullScreen = function() {
+ callback = null;
+ testExpected("document.webkitIsFullScreen", true);
+ if (window.testRunner && eventSender.keyDown) {
+ waitForEvent(document, 'keypress', keyPressed);
+ eventSender.keyDown('a', []);
+ eventSender.keyDown(' ', []);
}
- waitForEvent(document, 'webkitfullscreenchange', fullscreenChanged);
+ };
- var span = document.getElementsByTagName('span')[0];
- callback = spanEnteredFullScreen;
- runWithKeyDown(function(){span.webkitRequestFullScreen()});
+ var keyPressed = function(event) {
+ testExpected('event.keyCode', 32); // Space
+ endTest();
+ document.webkitCancelFullScreen();
}
+ waitForEvent(document, 'webkitfullscreenchange', fullscreenChanged);
+
+ var span = document.getElementsByTagName('span')[0];
+ callback = spanEnteredFullScreen;
+ runWithKeyDown(function(){span.webkitRequestFullScreen()});
</script>
« no previous file with comments | « LayoutTests/fullscreen/full-screen-iframe-zIndex.html ('k') | LayoutTests/fullscreen/full-screen-keyboard-enabled.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698