Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: LayoutTests/fullscreen/full-screen-cancel.html

Issue 462253003: Remove early returns in fullscreen tests (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fullscreen/full-screen-cancel.html
diff --git a/LayoutTests/fullscreen/full-screen-cancel.html b/LayoutTests/fullscreen/full-screen-cancel.html
index d670b14a5ba9ee3144f943339d8409690f98920e..d71f5d9bf87f8fbc31a8efec5e30420056fa0272 100644
--- a/LayoutTests/fullscreen/full-screen-cancel.html
+++ b/LayoutTests/fullscreen/full-screen-cancel.html
@@ -2,42 +2,36 @@
<script src="full-screen-test.js"></script>
<span></span>
<script>
- // Bail out early if the full screen API is not enabled or is missing:
- if (Element.prototype.webkitRequestFullScreen == undefined) {
- logResult(false, "Element.prototype.webkitRequestFullScreen == undefined");
- endTest();
- } else {
- var callback;
- var fullscreenChanged = function(event)
- {
- if (callback)
- callback(event)
- };
- waitForEvent(document, 'webkitfullscreenchange', fullscreenChanged);
+ var callback;
+ var fullscreenChanged = function(event)
+ {
+ if (callback)
+ callback(event)
+ };
+ waitForEvent(document, 'webkitfullscreenchange', fullscreenChanged);
- var span = document.getElementsByTagName('span')[0];
+ var span = document.getElementsByTagName('span')[0];
- var spanEnteredFullScreen = function() {
- testExpected("document.webkitIsFullScreen", true);
- testExpected("document.webkitCurrentFullScreenElement", span);
- callback = cancelledFullScreen;
- document.webkitCancelFullScreen();
- };
+ var spanEnteredFullScreen = function() {
+ testExpected("document.webkitIsFullScreen", true);
+ testExpected("document.webkitCurrentFullScreenElement", span);
+ callback = cancelledFullScreen;
+ document.webkitCancelFullScreen();
+ };
- var cancelledFullScreen = function() {
- testExpected("document.webkitIsFullScreen", false);
- testExpected("document.webkitCurrentFullScreenElement", undefined);
- callback = failFullScreenTest;
- document.webkitCancelFullScreen();
- setTimeout(endTest, 0);
- };
+ var cancelledFullScreen = function() {
+ testExpected("document.webkitIsFullScreen", false);
+ testExpected("document.webkitCurrentFullScreenElement", undefined);
+ callback = failFullScreenTest;
+ document.webkitCancelFullScreen();
+ setTimeout(endTest, 0);
+ };
- var failFullScreenTest = function() {
- consoleWrite("Should not have received a webkitfullscreenchange event.");
- endTest();
- };
+ var failFullScreenTest = function() {
+ consoleWrite("Should not have received a webkitfullscreenchange event.");
+ endTest();
+ };
- callback = spanEnteredFullScreen;
- runWithKeyDown(function(){span.webkitRequestFullScreen()});
- }
+ callback = spanEnteredFullScreen;
+ runWithKeyDown(function(){span.webkitRequestFullScreen()});
</script>

Powered by Google App Engine
This is Rietveld 408576698