Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 462183002: Add SHA1 hash of experience sampling extension to whitelist. (Closed)

Created:
6 years, 4 months ago by Chris Thompson
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add SHA1 hash of experience sampling extension to whitelist. BUG=384635 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289694

Patch Set 1 #

Total comments: 2

Patch Set 2 : Put hash on own line to keep <80char length #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/common/extensions/api/_permission_features.json View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Chris Thompson
mkwst@ -- could you PTAL for OWNERS approval? Thanks.
6 years, 4 months ago (2014-08-12 21:26:06 UTC) #1
Mike West
I'm only an OWNER for documentation changes; forwarding this to kalman@ who might have time ...
6 years, 4 months ago (2014-08-13 13:58:17 UTC) #2
not at google - send to devlin
lgtm https://codereview.chromium.org/462183002/diff/1/chrome/common/extensions/api/_permission_features.json File chrome/common/extensions/api/_permission_features.json (right): https://codereview.chromium.org/462183002/diff/1/chrome/common/extensions/api/_permission_features.json#newcode456 chrome/common/extensions/api/_permission_features.json:456: "whitelist": ["0B5B953E53AC1859AC1DD3F67E115D1A5C2D6123"] // https://crbug.com/384635 Note how the other ...
6 years, 4 months ago (2014-08-13 17:22:42 UTC) #3
Chris Thompson
https://codereview.chromium.org/462183002/diff/1/chrome/common/extensions/api/_permission_features.json File chrome/common/extensions/api/_permission_features.json (right): https://codereview.chromium.org/462183002/diff/1/chrome/common/extensions/api/_permission_features.json#newcode456 chrome/common/extensions/api/_permission_features.json:456: "whitelist": ["0B5B953E53AC1859AC1DD3F67E115D1A5C2D6123"] // https://crbug.com/384635 On 2014/08/13 17:22:42, kalman wrote: ...
6 years, 4 months ago (2014-08-13 17:32:27 UTC) #4
Chris Thompson
The CQ bit was checked by cthomp@chromium.org
6 years, 4 months ago (2014-08-13 17:32:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cthomp@chromium.org/462183002/20001
6 years, 4 months ago (2014-08-13 17:34:10 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-14 05:06:28 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-14 11:08:57 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/5546)
6 years, 4 months ago (2014-08-14 11:08:58 UTC) #9
Chris Thompson
The CQ bit was checked by cthomp@chromium.org
6 years, 4 months ago (2014-08-14 20:50:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cthomp@chromium.org/462183002/20001
6 years, 4 months ago (2014-08-14 20:52:58 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 20:55:33 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (20001) as 289694

Powered by Google App Engine
This is Rietveld 408576698