Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 462163002: Use a minimum touch size for selection handle hit testing (Closed)

Created:
6 years, 4 months ago by jdduke (slow)
Modified:
6 years, 4 months ago
Reviewers:
cjhopman
CC:
chromium-reviews, darin-cc_chromium.org, jdduke+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use a minimum touch size for selection handle hit testing Certain Android devices, as well as stylus and mouse inputs, may report zero for the touch size. These sizes are used when constructing the rect for touch handle insersection tests. However, gfx::RectBase will always report false when performing the intersection test if either rect is empty. Add an appropriate epsilon minimum touch size when forming the touch bounding box rect. BUG=402795 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289501

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M content/browser/renderer_host/input/touch_handle.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M content/browser/renderer_host/input/touch_handle_unittest.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jdduke (slow)
cjhopman@: PTAL, thanks. Didn't realize this until inspecting the RectBase::Intersect source code. I also reduced ...
6 years, 4 months ago (2014-08-12 18:45:58 UTC) #1
cjhopman
lgtm
6 years, 4 months ago (2014-08-13 23:31:09 UTC) #2
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 4 months ago (2014-08-13 23:40:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/462163002/1
6 years, 4 months ago (2014-08-13 23:45:29 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 09:41:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 289501

Powered by Google App Engine
This is Rietveld 408576698